You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by pm...@apache.org on 2018/12/12 21:42:52 UTC
samza git commit: Minor: properly close KafkaCheckpointManager in
TestKafkaCheckpointManager
Repository: samza
Updated Branches:
refs/heads/master 7b58d5ca0 -> 85830be9c
Minor: properly close KafkaCheckpointManager in TestKafkaCheckpointManager
Higher versions of KafkaServerTestHarness will validate that certain threads are no longer alive when the test class exits. Eventually, when kafka is upgraded, that validation would fail.
Author: Cameron Lee <ca...@linkedin.com>
Reviewers: Prateek Maheshwari <pm...@apache.org>
Closes #856 from cameronlee314/kcm_test
Project: http://git-wip-us.apache.org/repos/asf/samza/repo
Commit: http://git-wip-us.apache.org/repos/asf/samza/commit/85830be9
Tree: http://git-wip-us.apache.org/repos/asf/samza/tree/85830be9
Diff: http://git-wip-us.apache.org/repos/asf/samza/diff/85830be9
Branch: refs/heads/master
Commit: 85830be9cd1f418889e2b382564972f86ba309cc
Parents: 7b58d5c
Author: Cameron Lee <ca...@linkedin.com>
Authored: Wed Dec 12 13:42:48 2018 -0800
Committer: Prateek Maheshwari <pm...@apache.org>
Committed: Wed Dec 12 13:42:48 2018 -0800
----------------------------------------------------------------------
.../apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala | 1 +
1 file changed, 1 insertion(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/samza/blob/85830be9/samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala
----------------------------------------------------------------------
diff --git a/samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala b/samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala
index 5abbea9..0a0aae8 100644
--- a/samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala
+++ b/samza-kafka/src/test/scala/org/apache/samza/checkpoint/kafka/TestKafkaCheckpointManager.scala
@@ -233,6 +233,7 @@ class TestKafkaCheckpointManager extends KafkaServerTestHarness {
kcm.register(taskName)
kcm.start
kcm.writeCheckpoint(taskName, checkpoint)
+ kcm.stop
}
private def createTopic(cpTopic: String, partNum: Int, props: Properties) = {