You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "jihuayu (via GitHub)" <gi...@apache.org> on 2024/01/28 02:33:16 UTC
[PR] Add "pr.base" and "pr.ref" parameters to sonar-scanner [kvrocks]
jihuayu opened a new pull request, #2063:
URL: https://github.com/apache/kvrocks/pull/2063
Fix #2058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix SonarCloud analysis run on PR branch has wrong coverage on New Code [kvrocks]
Posted by "jihuayu (via GitHub)" <gi...@apache.org>.
jihuayu commented on PR #2063:
URL: https://github.com/apache/kvrocks/pull/2063#issuecomment-1913460660
> IMHO the `fetch-depth: 0` SHOULD NOT be removed. Otherwise the blame information cannot be uploaded to sonarcloud.
>
> ```
> WARN: Shallow clone detected, no blame information will be provided. You can convert to non-shallow with 'git fetch --unshallow'.
> INFO: SCM Publisher 0/285 source files have been analyzed (done) | time=3ms
> WARN: Missing blame information for the following files:
> ```
>
> If you clone a repository with only one commit, Git cannot distinguish which lines belong to each author.
Ohh，I misunderstood the meaning of the "depth" parameter.
It seems there are still issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix SonarCloud analysis run on PR branch has wrong coverage on New Code [kvrocks]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #2063:
URL: https://github.com/apache/kvrocks/pull/2063#issuecomment-1913429449
IMHO the fetch-depth SHOULD NOT be removed. Otherwise the blame information cannot be uploaded to sonarcloud.
```
WARN: Shallow clone detected, no blame information will be provided. You can convert to non-shallow with 'git fetch --unshallow'.
INFO: SCM Publisher 0/285 source files have been analyzed (done) | time=3ms
WARN: Missing blame information for the following files:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add "pr.base" and "pr.ref" parameters to sonar-scanner [kvrocks]
Posted by "jihuayu (via GitHub)" <gi...@apache.org>.
jihuayu commented on PR #2063:
URL: https://github.com/apache/kvrocks/pull/2063#issuecomment-1913428106
> Actually I don't think there's any problem for sonarcloud to automatically detect the target and base branch.
I know now! I also remove the checkout step depth, it works!
https://sonarcloud.io/summary/new_code?id=jihuayu_kvrocks-test&pullRequest=1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix SonarCloud analysis run on PR branch has wrong coverage on New Code [kvrocks]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on code in PR #2063:
URL: https://github.com/apache/kvrocks/pull/2063#discussion_r1468754941
##########
.github/workflows/sonar.yaml:
##########
@@ -32,7 +32,6 @@ jobs:
with:
repository: ${{ github.event.workflow_run.head_repository.full_name }}
ref: ${{ github.event.workflow_run.head_sha }}
- fetch-depth: 0
Review Comment:
See above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix SonarCloud analysis run on PR branch has wrong coverage on New Code [kvrocks]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2063:
URL: https://github.com/apache/kvrocks/pull/2063#issuecomment-1913439807
## [](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=2063) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_kvrocks&pullRequest=2063&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kvrocks&pullRequest=2063&resolved=false&inNewCodePeriod=true)
No data about Coverage
No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_kvrocks&pullRequest=2063)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add "pr.base" and "pr.ref" parameters to sonar-scanner [kvrocks]
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #2063:
URL: https://github.com/apache/kvrocks/pull/2063#issuecomment-1913423609
Actually I don't think there's any problem for sonarcloud to automatically detect the target and base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix SonarCloud analysis run on PR branch has wrong coverage on New Code [kvrocks]
Posted by "jihuayu (via GitHub)" <gi...@apache.org>.
jihuayu closed pull request #2063: Fix SonarCloud analysis run on PR branch has wrong coverage on New Code
URL: https://github.com/apache/kvrocks/pull/2063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org