You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by luckylooke <gi...@git.apache.org> on 2017/06/22 13:50:51 UTC

[GitHub] cordova-plugin-screen-orientation pull request #17: Update package.json

GitHub user luckylooke opened a pull request:

    https://github.com/apache/cordova-plugin-screen-orientation/pull/17

    Update package.json

    minor change
    
    The plugin uses IonicNativePlugin from ionic-native / core version (3.6.1), so plugin need to have this specified, for earlier versions it causes error: https://stackoverflow.com/questions/43650747/module-has-no-exported-member-ionicnativeplugin-ionic2


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/luckylooke/cordova-plugin-screen-orientation patch-3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-screen-orientation/pull/17.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17
    
----
commit e4a9c80677912cd4f3ef21602c250b309277ccc1
Author: Ctibor Laky <lu...@gmail.com>
Date:   2017-06-22T13:49:54Z

    Update package.json
    
    The plugin uses IonicNativePlugin from ionic-native / core version (3.6.1), so plugin need to have this specified, for earlier versions it causes error: https://stackoverflow.com/questions/43650747/module-has-no-exported-member-ionicnativeplugin-ionic2

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation pull request #17: Update package.json

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-plugin-screen-orientation/pull/17


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation issue #17: Update package.json

Posted by luckylooke <gi...@git.apache.org>.
Github user luckylooke commented on the issue:

    https://github.com/apache/cordova-plugin-screen-orientation/pull/17
  
    I am sorry, this has to be some mistake on my side.. I cannot recall how I came into this. 🤔 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-plugin-screen-orientation issue #17: Update package.json

Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:

    https://github.com/apache/cordova-plugin-screen-orientation/pull/17
  
    This plugin does not use anything from the ionic ecosystem. Cordova does not depend on ionic - perhaps the other way around is true (ionic depends on cordova). I will close this down.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org