[GitHub] [royale-asjs] greg-dove commented on pull request #942: mx.messaging.channels.URLVariables: implemented for HTTPService.request in MXRoyale / SparkRoyale

[GitBox <gi...@apache.org>]

greg-dove commented on pull request #942:
URL: https://github.com/apache/royale-asjs/pull/942#issuecomment-731840901


   Thanks very much for your contribution. I added the org.apache.royale.net.URLVariables implementation at some point and did not look in MXRoyale at the time. The URLVariables implementation is useful in general outside of the flex emulation code. So the main issue here is that the MXRoyale 'implementation' is not really an implementation, but an empty 'stub' class. Here's what I'd like to suggest: instead of adding the subclass in MXRoyale, we remove it and substitute the working version from the Network library. It is only used in one place inside DirectHTTPChannel and can be considered an 'internal' utility support only. This would get that part working like it should, and removes a redundant layer of inheritance. And if you need the class in any local code it is still available for import from the Network library. Would you be happy with that?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org