You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by mi...@apache.org on 2017/11/03 15:15:43 UTC

[3/5] incubator-impala git commit: Correct log line in start-impala-cluster.py.

Correct log line in start-impala-cluster.py.

Updated logging in start-impala-cluster to accurately specify how many
impala nodes were started, and how many of these were coordinators or
executors or both. The new logging looks like:

  Impala Cluster Running with 1 nodes (1 coordinators, 1 executors).

Previously, when invoking this script with --cluster_size=1, it would
report "1 nodes and 3 coordinators" which was wrong (because there was
only 1 coordinator) and confusing (because it seemed like a coordinator
was a separate thing from a node).

I also removed an unused import.

I have run core and exhaustive tests with these change, as part of
testing other changes. Nothing untoward happened.

Change-Id: I7ceece1c05b9a4ca9f0a08fa30d195f811490c0e
Reviewed-on: http://gerrit.cloudera.org:8080/8432
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins


Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/5edbb153
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/5edbb153
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/5edbb153

Branch: refs/heads/master
Commit: 5edbb15335034900847c5d329da10260cf961126
Parents: 0a0affb
Author: Philip Zeyliger <ph...@cloudera.com>
Authored: Fri Oct 27 20:33:32 2017 -0700
Committer: Impala Public Jenkins <im...@gerrit.cloudera.org>
Committed: Fri Nov 3 02:12:00 2017 +0000

----------------------------------------------------------------------
 bin/start-impala-cluster.py | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/5edbb153/bin/start-impala-cluster.py
----------------------------------------------------------------------
diff --git a/bin/start-impala-cluster.py b/bin/start-impala-cluster.py
index af960d9..670e693 100755
--- a/bin/start-impala-cluster.py
+++ b/bin/start-impala-cluster.py
@@ -26,7 +26,6 @@ import sys
 from getpass import getuser
 from time import sleep, time
 from optparse import OptionParser
-from testdata.common import cgroups
 
 KUDU_MASTER_HOSTS = os.getenv('KUDU_MASTER_HOSTS', '127.0.0.1')
 DEFAULT_IMPALA_MAX_LOG_FILES = os.environ.get('IMPALA_MAX_LOG_FILES', 10)
@@ -395,5 +394,11 @@ if __name__ == "__main__":
     print 'Error starting cluster: %s' % e
     sys.exit(1)
 
-  print 'Impala Cluster Running with %d nodes and %d coordinators.' % (
-      options.cluster_size, options.num_coordinators)
+  if options.use_exclusive_coordinators == True:
+    executors = options.cluster_size - options.num_coordinators
+  else:
+    executors = options.cluster_size
+  print 'Impala Cluster Running with %d nodes (%d coordinators, %d executors).' % (
+      options.cluster_size,
+      min(options.cluster_size, options.num_coordinators),
+      executors)