You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/03 00:51:27 UTC
[I] [BUG] RuleDataRefresh.refresh() NPE on null data / no-op on empty data (HTTP sync) [shenyu]
Aias00 opened a new issue, #6663:
URL: https://github.com/apache/shenyu/issues/6663
- Severity: High
- Location:
`shenyu-sync-data-center/shenyu-sync-data-http/src/main/java/org/apache/shenyu/sync/data/http/refresh/RuleDataRefresh.java:71-81`
-
Description:
Identical bug to SYNC-3 but for rules. `data.forEach(pluginDataSubscriber::unRuleSubscribe)` is called when `CollectionUtils.isEmpty(data)` is true. NPE if null, no-op if empty.
-
Impact:
HTTP sync refresh with empty/null rule group crashes or leaves stale rules.
-
Suggested fix:
Call `refreshRuleDataAll()` first, return early when empty.
-
Confidence: High
---
_Identified during the 2026-08-02 deep re-scan; full list in [`docs/scan2-2026-08-02/00-consolidated-critical-high.md`](docs/scan2-2026-08-02/00-consolidated-critical-high.md)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [BUG] RuleDataRefresh.refresh() NPE on null data / no-op on empty data (HTTP sync) [shenyu]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #6663:
URL: https://github.com/apache/shenyu/issues/6663#issuecomment-5161213445
👋 Hello @Aias00
A new issue has been opened by @Aias00:
- **Title**: [BUG] RuleDataRefresh.refresh() NPE on null data / no-op on empty data (HTTP sync)
- **Link**: https://github.com/apache/shenyu/issues/6663
Please review when you have time. Thank you! 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [BUG] RuleDataRefresh.refresh() NPE on null data / no-op on empty data (HTTP sync) [shenyu]
Posted by "Aias00 (via GitHub) via notifications" <no...@shenyu.apache.org>.
Aias00 commented on issue #6663:
URL: https://github.com/apache/shenyu/issues/6663#issuecomment-6791278580
Verified against current master (9dd9a12fb). `RuleDataRefresh.refresh()` calls `refreshRuleDataAll()` first and returns early for null or empty data (merged PR #6925). Closing as resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [BUG] RuleDataRefresh.refresh() NPE on null data / no-op on empty data (HTTP sync) [shenyu]
Posted by "wy471x (via GitHub)" <gi...@apache.org>.
wy471x commented on issue #6663:
URL: https://github.com/apache/shenyu/issues/6663#issuecomment-5975498220
/assign
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [BUG] RuleDataRefresh.refresh() NPE on null data / no-op on empty data (HTTP sync) [shenyu]
Posted by "sunnysabor (via GitHub)" <gi...@apache.org>.
sunnysabor commented on issue #6663:
URL: https://github.com/apache/shenyu/issues/6663#issuecomment-5936744946
Verified against current `upstream/master` at `69399fe5` (merged PR #6925): `RuleDataRefresh.refresh()` now calls `refreshRuleDataAll()` before checking `CollectionUtils.isEmpty(data)` and returns immediately for null or empty input. The regression test `RuleDataRefreshTest#testRefreshWithNullData` verifies the null case; empty input follows the same clearing branch. This appears to resolve the reported stale-cache/NPE behavior, so the issue can be closed if maintainers agree. Code: https://github.com/apache/shenyu/blob/69399fe5af8ddddf55fbc863d4c6c428de8ac4f6/shenyu-sync-data-center/shenyu-sync-data-http/src/main/java/org/apache/shenyu/sync/data/http/refresh/RuleDataRefresh.java#L69-L77 Test: https://github.com/apache/shenyu/blob/69399fe5af8ddddf55fbc863d4c6c428de8ac4f6/shenyu-sync-data-center/shenyu-sync-data-http/src/test/java/org/apache/shenyu/sync/data/http/refresh/RuleDataRefreshTest.java#L82-L94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [BUG] RuleDataRefresh.refresh() NPE on null data / no-op on empty data (HTTP sync) [shenyu]
Posted by "Aias00 (via GitHub) via notifications" <no...@shenyu.apache.org>.
Aias00 closed issue #6663: [BUG] RuleDataRefresh.refresh() NPE on null data / no-op on empty data (HTTP sync)
URL: https://github.com/apache/shenyu/issues/6663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org