You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/20 16:02:41 UTC
[jira] [Commented] (BEAM-1579) Runners should verify that PT
overrides converged
[ https://issues.apache.org/jira/browse/BEAM-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932915#comment-15932915 ]
ASF GitHub Bot commented on BEAM-1579:
--------------------------------------
GitHub user tgroh opened a pull request:
https://github.com/apache/beam/pull/2274
[BEAM-1579] Add a Batch-Surgery API
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
This takes a list, applies all overrides in the order of the list, and
validates that no more overrides are applicable.
Port the DirectRunner to this API
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/beam ordered_overrides
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2274.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2274
----
commit 4c9c0748cb0c41d2ec49acc58348eae90fa62ca0
Author: Thomas Groh <tg...@google.com>
Date: 2017-03-17T23:17:20Z
Provide methods for validating Surgery completion
This takes a list, applies all overrides in the order of the list, and
validates that no more overrides are applicable.
commit 9fb14a932b3c77baac02013227a4dd0af3d4a1bf
Author: Thomas Groh <tg...@google.com>
Date: 2017-03-17T23:39:58Z
Port the DirectRunner to the Group Surgery API
----
> Runners should verify that PT overrides converged
> -------------------------------------------------
>
> Key: BEAM-1579
> URL: https://issues.apache.org/jira/browse/BEAM-1579
> Project: Beam
> Issue Type: Bug
> Components: runner-core, runner-dataflow, runner-direct
> Reporter: Eugene Kirpichov
> Assignee: Thomas Groh
>
> PT overrides are applied in order, see https://issues.apache.org/jira/browse/BEAM-1578 .
> To make sure that the order is correct and avoid confusing errors, after applying the overrides in order, we should verify that the pipeline has converged, i.e. the overrides no longer match.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)