You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "liurenjie1024 (via GitHub)" <gi...@apache.org> on 2023/05/24 11:24:58 UTC
[GitHub] [arrow-datafusion] liurenjie1024 opened a new pull request, #6435: Add tpch test cases with data.
liurenjie1024 opened a new pull request, #6435:
URL: https://github.com/apache/arrow-datafusion/pull/6435
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Part of #6405, but not complete.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Current tpch test is incomplete since some query produces no data.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Ported tests case from other db system so that all queries contains data.
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
Yes, tested with `cargo test -p datafusion --test sqllogictests -- tpch/tpch.slt`
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #6435: Add tpch test cases with data.
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6435:
URL: https://github.com/apache/arrow-datafusion/pull/6435#issuecomment-1568970790
I was able to run these tests locally following the directions 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #6435: Add tpch test cases with data.
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #6435:
URL: https://github.com/apache/arrow-datafusion/pull/6435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] liurenjie1024 commented on pull request #6435: Add tpch test cases with data.
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on PR #6435:
URL: https://github.com/apache/arrow-datafusion/pull/6435#issuecomment-1566517903
I think this is ready for review. cc @comphead @alamb @jackwener
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on pull request #6435: Add tpch test cases with data.
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #6435:
URL: https://github.com/apache/arrow-datafusion/pull/6435#issuecomment-1563205222
> Not sure we need to have all that inserts Imho its better to use existing approach with sqllogictest like
agree with you, it's easier to maintain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #6435: Add tpch test cases with data.
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6435:
URL: https://github.com/apache/arrow-datafusion/pull/6435#issuecomment-1563502104
In terms of conditionally running the tests, perhaps we can special case tests that start with `tpch_` the way we do with `pg_compat` tests: https://github.com/apache/arrow-datafusion/tree/main/datafusion/core/tests/sqllogictests#running-tests-postgres-compatibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6435: Add tpch test cases with data.
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #6435:
URL: https://github.com/apache/arrow-datafusion/pull/6435#discussion_r1210728576
##########
.github/workflows/rust.yml:
##########
@@ -197,18 +197,17 @@ jobs:
rust-version: stable
- name: Generate benchmark data and expected query results
run: |
- mkdir -p benchmarks/data/answers
+ mkdir -p datafusion/core/tests/sqllogictests/test_files/tpch/data
git clone https://github.com/databricks/tpch-dbgen.git
cd tpch-dbgen
make
- ./dbgen -f -s 1
- mv *.tbl ../benchmarks/data
- mv ./answers/* ../benchmarks/data/answers/
+ ./dbgen -f -s 0.1
Review Comment:
I looked into this a little more -- and note we are running this CI check sf 0.1 (rather than SF1) It seems like a good idea and means it takes only 8 seconds to make the data 👍
https://github.com/apache/arrow-datafusion/actions/runs/5108217213/jobs/9181887855?pr=6435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] liurenjie1024 commented on pull request #6435: Add tpch test cases with data.
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on PR #6435:
URL: https://github.com/apache/arrow-datafusion/pull/6435#issuecomment-1563703996
Oh, I didn't notice that we already have tpch verification in ci, so another round of tpch verification would not be necessary. The main goal of this pr is to move tpch test in benchmark into sqllogictest to make it easier to maintain, so I will remove unnecessary changes to avoid.
> Figure out some way to run the tpch tests conditionally in CI (maybe an environment variable or a flag 🤔 ) so they still pass even when the data generator hasn't been run.
Do we really need to make it conditional? 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org