[GitHub] [spark] amaliujia commented on a diff in pull request #38007: [SPARK-40566][SQL] Add showIndex function

[GitBox <gi...@apache.org>]

amaliujia commented on code in PR #38007:
URL: https://github.com/apache/spark/pull/38007#discussion_r981636250


##########
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCV2Suite.scala:
##########
@@ -2635,6 +2635,10 @@ class JDBCV2Suite extends QueryTest with SharedSparkSession with ExplainSuiteHel
     val tableIndex = indexes2.head
     assert(tableIndex.indexName() == "people_index")
 
+
+    val df = sql(s"SHOW INDEX ON TABLE h2.test.people")
+    checkAnswer(df, Seq(Row("people_index", "INDEX", Array("ID"), Map(), Map())))

Review Comment:
   Is it possible to also test 
   
   ```
           tableIndex.columnProperties().asScala.toMap,
           tableIndex.properties().asScala.toMap))
   ```
   
   Which are two empty maps here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org