[jira] [Commented] (MJAVADOC-644) StaleHelper does not close DirectoryStream

["Michael Osipov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MJAVADOC-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17062051#comment-17062051 ] 

Michael Osipov commented on MJAVADOC-644:
-----------------------------------------

Can you provide a PR?

> StaleHelper does not close DirectoryStream
> ------------------------------------------
>
>                 Key: MJAVADOC-644
>                 URL: https://issues.apache.org/jira/browse/MJAVADOC-644
>             Project: Maven Javadoc Plugin
>          Issue Type: Bug
>    Affects Versions: 3.2.0
>            Reporter: Marc Philipp
>            Priority: Major
>
> The {{StaleHelper}} class introduced in 3.2.0 creates a new {{DirectoryStream}} but fails to close it:
> https://github.com/apache/maven-javadoc-plugin/compare/maven-javadoc-plugin-3.1.1..maven-javadoc-plugin-3.2.0#diff-5eee595ccbfac461074d6b07d8983a14R145
> We're using [Takari's embedded Maven launcher|https://github.com/takari/takari-plugin-testing-project] in our integration tests and this resource leakage causes our tests to fail.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)