[GitHub] [superset] rusackas commented on a change in pull request #19112: fix: Dashboard import holding issue

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #19112:
URL: https://github.com/apache/superset/pull/19112#discussion_r829687530



##########
File path: superset-frontend/src/views/CRUD/hooks.ts
##########
@@ -464,7 +467,7 @@ export function useImportResource(
           updateState({ loading: false });
         });
     },
-    [],
+    [handleErrorMsg, resourceLabel, resourceName],

Review comment:
       Everyone keeps pinging this other guy 🤣 
   
   Appreciate the keen eyes on memoization, however. Generally, it's great to fix perf issues like this as bycatch, but I'm perfectly OK with filing a separate issue. That might help both PRs get through faster, and prevent larger "slippery slope" PRs.
   
   Let's just not lose track of the task... similar memoization (or lack thereof) issues have been cropping up all over, and the gains from fixing them are tangible.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org