You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/11/21 03:41:25 UTC
[GitHub] [pulsar] leizhiyuan opened a new pull request, #18263: [improve][broker] allow client skips the non-continued deleted ranges stats
leizhiyuan opened a new pull request, #18263:
URL: https://github.com/apache/pulsar/pull/18263
Fixes #18240
<!-- or this PR is one task of an issue -->
Master Issue: #18240
### Motivation
<!-- Explain here the context, and why you're making that change. What is the problem you're trying to solve. -->
### Modifications
<!-- Describe the modifications you've done. -->
add a flag getTotalNonContiguousDeletedMessagesRange to allow users can skip the non-continued deleted ranges stats
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
https://github.com/leizhiyuan/pulsar/pull/5
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [x] The REST endpoints
- [ ] The admin CLI options
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #18263: [improve][broker] allow client skips the non-continued deleted ranges stats
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on PR #18263:
URL: https://github.com/apache/pulsar/pull/18263#issuecomment-1316151984
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] WJL3333 commented on a diff in pull request #18263: [improve][broker] allow client skips the non-continued deleted ranges stats
Posted by GitBox <gi...@apache.org>.
WJL3333 commented on code in PR #18263:
URL: https://github.com/apache/pulsar/pull/18263#discussion_r1010303185
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -1435,14 +1437,15 @@ protected void internalGetPartitionedStats(AsyncResponse asyncResponse, boolean
.thenCompose(owned -> {
if (owned) {
return getTopicReferenceAsync(partition)
- .thenApply(ref ->
- ref.getStats(getPreciseBacklog, subscriptionBacklogSize,
- getEarliestTimeInBacklog));
+ .thenApply(ref ->
+ ref.getStats(getPreciseBacklog, subscriptionBacklogSize,
Review Comment:
i think we can add some class `XXXXOption` to encapsulate these boolean config.
if we add more boolean config it will be easy to just change `XXXXOption` without too much change the related code. And it improves the code quality to make method signature with less parameter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #18263: [improve][broker] allow client skips the non-continued deleted ranges stats
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #18263:
URL: https://github.com/apache/pulsar/pull/18263#issuecomment-1362298465
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] leizhiyuan commented on pull request #18263: feat:allow client skips the non-continued deleted ranges stats
Posted by GitBox <gi...@apache.org>.
leizhiyuan commented on PR #18263:
URL: https://github.com/apache/pulsar/pull/18263#issuecomment-1296570218
maybe we should use GetStatsOptions next pr, not original name like getPreciseBacklog,subscriptionBacklogSize etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] leizhiyuan commented on pull request #18263: [improve][broker] allow client skips the non-continued deleted ranges stats
Posted by GitBox <gi...@apache.org>.
leizhiyuan commented on PR #18263:
URL: https://github.com/apache/pulsar/pull/18263#issuecomment-1304679387
> > There is a failed broker test in your [leizhiyuan#4](https://github.com/leizhiyuan/pulsar/pull/4) : https://github.com/leizhiyuan/pulsar/actions/runs/3373856231/jobs/5598944551#step:10:1209
> > if it is caused by your change please fix it.
>
> [leizhiyuan#5](https://github.com/leizhiyuan/pulsar/pull/5)
>
> I didn't sync the master branch ,now I opened a new pr
<img width="1429" alt="image" src="https://user-images.githubusercontent.com/2684384/200148605-6a527f10-9f8e-49a9-9d14-cf8a5bfef282.png">
Add some case seems be flaky, It is not related with the pr， I ran ok in my machine。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on a diff in pull request #18263: [improve][broker] allow client skips the non-continued deleted ranges stats
Posted by GitBox <gi...@apache.org>.
nodece commented on code in PR #18263:
URL: https://github.com/apache/pulsar/pull/18263#discussion_r1027577873
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupUsageAggregationTest.java:
##########
@@ -210,7 +211,10 @@ private void verifyStats(String topicString, String rgName,
throws InterruptedException, PulsarAdminException {
BrokerService bs = pulsar.getBrokerService();
Awaitility.await().untilAsserted(() -> {
- TopicStatsImpl topicStats = bs.getTopicStats().get(topicString);
+ GetStatsOptions getStatsOptions =
+ GetStatsOptions.builder().getPreciseBacklog(false).subscriptionBacklogSize(false)
+ .getEarliestTimeInBacklog(false).getTotalNonContiguousDeletedMessagesRange(false).build();
Review Comment:
```suggestion
.getEarliestTimeInBacklog(false).getTotalNonContiguousDeletedMessagesRange(true).build();
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- closed pull request #18263: [improve][broker] allow client skips the non-continued deleted ranges stats
Posted by GitBox <gi...@apache.org>.
Technoboy- closed pull request #18263: [improve][broker] allow client skips the non-continued deleted ranges stats
URL: https://github.com/apache/pulsar/pull/18263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #18263: [improve][broker] allow client skips the non-continued deleted ranges stats
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18263:
URL: https://github.com/apache/pulsar/pull/18263#issuecomment-1543180912
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][broker] allow client skips the non-continued deleted ranges stats [pulsar]
Posted by "leizhiyuan (via GitHub)" <gi...@apache.org>.
leizhiyuan closed pull request #18263: [improve][broker] allow client skips the non-continued deleted ranges stats
URL: https://github.com/apache/pulsar/pull/18263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] leizhiyuan commented on pull request #18263: [improve][broker] allow client skips the non-continued deleted ranges stats
Posted by GitBox <gi...@apache.org>.
leizhiyuan commented on PR #18263:
URL: https://github.com/apache/pulsar/pull/18263#issuecomment-1304678989
> There is a failed broker test in your [leizhiyuan#4](https://github.com/leizhiyuan/pulsar/pull/4) : https://github.com/leizhiyuan/pulsar/actions/runs/3373856231/jobs/5598944551#step:10:1209
>
> if it is caused by your change please fix it.
https://github.com/leizhiyuan/pulsar/pull/5
I didn't sync the master branch ,now I opened a new pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #18263: [improve][broker] allow client skips the non-continued deleted ranges stats
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18263:
URL: https://github.com/apache/pulsar/pull/18263#issuecomment-1316188228
# [Codecov](https://codecov.io/gh/apache/pulsar/pull/18263?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18263](https://codecov.io/gh/apache/pulsar/pull/18263?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8460be2) into [master](https://codecov.io/gh/apache/pulsar/commit/46c0438ccc1460e22fc437a626a8c9cb05f4d618?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (46c0438) will **decrease** coverage by `3.94%`.
> The diff coverage is `47.16%`.
[](https://codecov.io/gh/apache/pulsar/pull/18263?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18263 +/- ##
============================================
- Coverage 38.84% 34.90% -3.95%
+ Complexity 8286 4709 -3577
============================================
Files 683 400 -283
Lines 67323 43651 -23672
Branches 7215 4477 -2738
============================================
- Hits 26152 15235 -10917
+ Misses 38210 26257 -11953
+ Partials 2961 2159 -802
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `34.90% <47.16%> (-3.95%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/18263?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...he/pulsar/broker/admin/v2/NonPersistentTopics.java](https://codecov.io/gh/apache/pulsar/pull/18263/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi92Mi9Ob25QZXJzaXN0ZW50VG9waWNzLmphdmE=) | `22.68% <ø> (-39.36%)` | :arrow_down: |
| [...rg/apache/pulsar/broker/service/BrokerService.java](https://codecov.io/gh/apache/pulsar/pull/18263/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL0Jyb2tlclNlcnZpY2UuamF2YQ==) | `48.46% <0.00%> (-9.46%)` | :arrow_down: |
| [...n/java/org/apache/pulsar/broker/service/Topic.java](https://codecov.io/gh/apache/pulsar/pull/18263/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL1RvcGljLmphdmE=) | `18.18% <ø> (ø)` | |
| [...oker/service/nonpersistent/NonPersistentTopic.java](https://codecov.io/gh/apache/pulsar/pull/18263/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL25vbnBlcnNpc3RlbnQvTm9uUGVyc2lzdGVudFRvcGljLmphdmE=) | `24.69% <0.00%> (-30.19%)` | :arrow_down: |
| [...ker/stats/prometheus/NamespaceStatsAggregator.java](https://codecov.io/gh/apache/pulsar/pull/18263/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zdGF0cy9wcm9tZXRoZXVzL05hbWVzcGFjZVN0YXRzQWdncmVnYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...pulsar/broker/admin/impl/PersistentTopicsBase.java](https://codecov.io/gh/apache/pulsar/pull/18263/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi9pbXBsL1BlcnNpc3RlbnRUb3BpY3NCYXNlLmphdmE=) | `17.76% <9.09%> (-34.81%)` | :arrow_down: |
| [...pache/pulsar/broker/admin/v2/PersistentTopics.java](https://codecov.io/gh/apache/pulsar/pull/18263/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi92Mi9QZXJzaXN0ZW50VG9waWNzLmphdmE=) | `13.16% <45.45%> (-57.56%)` | :arrow_down: |
| [...pache/pulsar/broker/admin/v1/PersistentTopics.java](https://codecov.io/gh/apache/pulsar/pull/18263/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi92MS9QZXJzaXN0ZW50VG9waWNzLmphdmE=) | `11.40% <57.14%> (-34.30%)` | :arrow_down: |
| [...sar/broker/service/persistent/PersistentTopic.java](https://codecov.io/gh/apache/pulsar/pull/18263/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3BlcnNpc3RlbnQvUGVyc2lzdGVudFRvcGljLmphdmE=) | `46.86% <83.33%> (-10.06%)` | :arrow_down: |
| [...sar/broker/resourcegroup/ResourceGroupService.java](https://codecov.io/gh/apache/pulsar/pull/18263/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9yZXNvdXJjZWdyb3VwL1Jlc291cmNlR3JvdXBTZXJ2aWNlLmphdmE=) | `32.97% <100.00%> (-4.80%)` | :arrow_down: |
| ... and [423 more](https://codecov.io/gh/apache/pulsar/pull/18263/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a diff in pull request #18263: [improve][broker] allow client skips the non-continued deleted ranges stats
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on code in PR #18263:
URL: https://github.com/apache/pulsar/pull/18263#discussion_r1010359577
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java:
##########
@@ -1212,9 +1212,13 @@ public void getStats(
+ "not to use when there's heavy traffic.")
@QueryParam("subscriptionBacklogSize") @DefaultValue("false") boolean subscriptionBacklogSize,
@ApiParam(value = "If return time of the earliest message in backlog")
- @QueryParam("getEarliestTimeInBacklog") @DefaultValue("false") boolean getEarliestTimeInBacklog) {
+ @QueryParam("getEarliestTimeInBacklog") @DefaultValue("false") boolean getEarliestTimeInBacklog,
+ @ApiParam(value = "If return If return TotalNonContiguousDeletedMessagesRange")
Review Comment:
Please check all.
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java:
##########
@@ -1212,9 +1212,13 @@ public void getStats(
+ "not to use when there's heavy traffic.")
@QueryParam("subscriptionBacklogSize") @DefaultValue("false") boolean subscriptionBacklogSize,
@ApiParam(value = "If return time of the earliest message in backlog")
- @QueryParam("getEarliestTimeInBacklog") @DefaultValue("false") boolean getEarliestTimeInBacklog) {
+ @QueryParam("getEarliestTimeInBacklog") @DefaultValue("false") boolean getEarliestTimeInBacklog,
+ @ApiParam(value = "If return If return TotalNonContiguousDeletedMessagesRange")
Review Comment:
```suggestion
@ApiParam(value = "If return the total non-continues deleted message range")
```
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -1435,14 +1437,15 @@ protected void internalGetPartitionedStats(AsyncResponse asyncResponse, boolean
.thenCompose(owned -> {
if (owned) {
return getTopicReferenceAsync(partition)
- .thenApply(ref ->
- ref.getStats(getPreciseBacklog, subscriptionBacklogSize,
- getEarliestTimeInBacklog));
+ .thenApply(ref ->
+ ref.getStats(getPreciseBacklog, subscriptionBacklogSize,
Review Comment:
Good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] labuladong commented on pull request #18263: [improve][broker] allow client skips the non-continued deleted ranges stats
Posted by GitBox <gi...@apache.org>.
labuladong commented on PR #18263:
URL: https://github.com/apache/pulsar/pull/18263#issuecomment-1299534355
There is a failed broker test in your https://github.com/leizhiyuan/pulsar/pull/4 :
https://github.com/leizhiyuan/pulsar/actions/runs/3373856231/jobs/5598944551#step:10:1209
if it is caused by your change please fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on a diff in pull request #18263: [improve][broker] allow client skips the non-continued deleted ranges stats
Posted by GitBox <gi...@apache.org>.
nodece commented on code in PR #18263:
URL: https://github.com/apache/pulsar/pull/18263#discussion_r1027577745
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/resourcegroup/RGUsageMTAggrWaitForAllMsgsTest.java:
##########
@@ -547,7 +548,10 @@ private void verifyRGProdConsStats(String[] topicStrings,
boolean checkConsume) throws Exception {
BrokerService bs = pulsar.getBrokerService();
- Map<String, TopicStatsImpl> topicStatsMap = bs.getTopicStats();
+ GetStatsOptions getStatsOptions =
+ GetStatsOptions.builder().getPreciseBacklog(false).subscriptionBacklogSize(false)
+ .getEarliestTimeInBacklog(false).getTotalNonContiguousDeletedMessagesRange(false).build();
Review Comment:
```suggestion
.getEarliestTimeInBacklog(false).getTotalNonContiguousDeletedMessagesRange(true).build();
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on pull request #18263: [improve][broker] allow client skips the non-continued deleted ranges stats
Posted by "poorbarcode (via GitHub)" <gi...@apache.org>.
poorbarcode commented on PR #18263:
URL: https://github.com/apache/pulsar/pull/18263#issuecomment-1502049131
@leizhiyuan could you please rebase master and take a look at the failed tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #18263: feat:allow client skips the non-continued deleted ranges stats
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #18263:
URL: https://github.com/apache/pulsar/pull/18263#issuecomment-1296571327
@leizhiyuan Please add the following content to your PR description and select a checkbox:
```
- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][broker] allow client skips the non-continued deleted ranges stats [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #18263:
URL: https://github.com/apache/pulsar/pull/18263#issuecomment-2411049477
related to #23380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] leizhiyuan commented on a diff in pull request #18263: [improve][broker] allow client skips the non-continued deleted ranges stats
Posted by GitBox <gi...@apache.org>.
leizhiyuan commented on code in PR #18263:
URL: https://github.com/apache/pulsar/pull/18263#discussion_r1027834453
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupUsageAggregationTest.java:
##########
@@ -210,7 +211,10 @@ private void verifyStats(String topicString, String rgName,
throws InterruptedException, PulsarAdminException {
BrokerService bs = pulsar.getBrokerService();
Awaitility.await().untilAsserted(() -> {
- TopicStatsImpl topicStats = bs.getTopicStats().get(topicString);
+ GetStatsOptions getStatsOptions =
+ GetStatsOptions.builder().getPreciseBacklog(false).subscriptionBacklogSize(false)
+ .getEarliestTimeInBacklog(false).getTotalNonContiguousDeletedMessagesRange(false).build();
Review Comment:
in resourcegroup ,we do not need this data. it will use much memory ,see https://github.com/apache/pulsar/issues/18240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] leizhiyuan commented on a diff in pull request #18263: [improve][broker] allow client skips the non-continued deleted ranges stats
Posted by GitBox <gi...@apache.org>.
leizhiyuan commented on code in PR #18263:
URL: https://github.com/apache/pulsar/pull/18263#discussion_r1010976883
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -1435,14 +1437,15 @@ protected void internalGetPartitionedStats(AsyncResponse asyncResponse, boolean
.thenCompose(owned -> {
if (owned) {
return getTopicReferenceAsync(partition)
- .thenApply(ref ->
- ref.getStats(getPreciseBacklog, subscriptionBacklogSize,
- getEarliestTimeInBacklog));
+ .thenApply(ref ->
+ ref.getStats(getPreciseBacklog, subscriptionBacklogSize,
Review Comment:
there has an GetStatsOptions ,but there has an usage somewhere. I will try to add a method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][broker] allow client skips the non-continued deleted ranges stats [pulsar]
Posted by "leizhiyuan (via GitHub)" <gi...@apache.org>.
leizhiyuan commented on PR #18263:
URL: https://github.com/apache/pulsar/pull/18263#issuecomment-2412422096
It's been too long (2 years) since the pull request. I can't even remember some of the code at that time. I will close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][broker] allow client skips the non-continued deleted ranges stats [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #18263:
URL: https://github.com/apache/pulsar/pull/18263#issuecomment-2411049372
please rebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #18263: [improve][broker] allow client skips the non-continued deleted ranges stats
Posted by github-actions.
github-actions[bot] commented on PR #18263:
URL: https://github.com/apache/pulsar/pull/18263#issuecomment-1401303628
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 commented on pull request #18263: [improve][broker] allow client skips the non-continued deleted ranges stats
Posted by GitBox <gi...@apache.org>.
congbobo184 commented on PR #18263:
URL: https://github.com/apache/pulsar/pull/18263#issuecomment-1364483714
could you please merge the `apache/master`, then rerun the test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org