[jira] [Commented] (COMPRESS-306) ArchiveStreamFactory fails to pass on the encoding when creating some streams

["Jeremy Gustie (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/COMPRESS-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15083294#comment-15083294 ] 

Jeremy Gustie commented on COMPRESS-306:
----------------------------------------

I know this already resolved, but I also just noticed this issue while trying to extend {{ArchiveStreamFactory}} (in some cases I do not want the factory to stream Zip or JAR files). It occurred to me that there was significant duplication in the code and was wondering if it would be better if {{createArchiveInputStream(InputStream)}} called through to {{createArchiveInputStream(String, InputStream)}} once the archive type was detected. This would limit the number of places the archive input stream constructors are invoked.

> ArchiveStreamFactory fails to pass on the encoding when creating some streams
> -----------------------------------------------------------------------------
>
>                 Key: COMPRESS-306
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-306
>             Project: Commons Compress
>          Issue Type: Bug
>    Affects Versions: 1.9
>            Reporter: Sebb
>             Fix For: 1.10
>
>
> ArchiveStreamFactory fails to pass on the encoding when creating the following streams (in some or all cases):
> * ArjArchiveInputStream
> * CpioArchiveInputStream
> * DumpArchiveInputStream
> * JarArchiveInputStream
> * JarArchiveOutputStream



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)