You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Carl Steinbach (JIRA)" <ji...@apache.org> on 2010/08/10 22:58:18 UTC
[jira] Created: (HIVE-1526) Hive should depend on a release version
of Thrift
Hive should depend on a release version of Thrift
-------------------------------------------------
Key: HIVE-1526
URL: https://issues.apache.org/jira/browse/HIVE-1526
Project: Hadoop Hive
Issue Type: Task
Components: Build Infrastructure
Reporter: Carl Steinbach
Hive should depend on a release version of Thrift, and ideally it should use Ivy to resolve this dependency.
The Thrift folks are working on adding Thrift artifacts to a maven repository here: https://issues.apache.org/jira/browse/THRIFT-363
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
RE: how jdbm is used in map join
Posted by Joydeep Sen Sarma <js...@facebook.com>.
i believe each mapper makes a copy since it reads in the data to be loaded into the dbm.
this needs to be optimized at some point (ideally we should be putting the dbm in distributed cache)
________________________________________
From: Gang Luo [lgpublic@yahoo.com.cn]
Sent: Tuesday, August 10, 2010 3:04 PM
To: hive-dev@hadoop.apache.org
Subject: how jdbm is used in map join
Hi all,
Hive uses JDBM for the replicate table in map join. When multiple map tasks are
running on the same node, will there be multiple copis of JDBM file generated,
or will all the map task share the same copy? If it is the later, which mapper
generates the file, and how to synchronize other mappers?
Thanks,
-Gang
how jdbm is used in map join
Posted by Gang Luo <lg...@yahoo.com.cn>.
Hi all,
Hive uses JDBM for the replicate table in map join. When multiple map tasks are
running on the same node, will there be multiple copis of JDBM file generated,
or will all the map task share the same copy? If it is the later, which mapper
generates the file, and how to synchronize other mappers?
Thanks,
-Gang
[jira] Commented: (HIVE-1526) Hive should depend on a release
version of Thrift
Posted by "Ning Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916741#action_12916741 ]
Ning Zhang commented on HIVE-1526:
----------------------------------
Carl and Todd, is this a blocking issue for 0.6? If not, we can make it in 0.7 and get 0.6 release ASAP.
> Hive should depend on a release version of Thrift
> -------------------------------------------------
>
> Key: HIVE-1526
> URL: https://issues.apache.org/jira/browse/HIVE-1526
> Project: Hadoop Hive
> Issue Type: Task
> Components: Build Infrastructure, Clients
> Reporter: Carl Steinbach
> Assignee: Todd Lipcon
> Fix For: 0.6.0, 0.7.0
>
> Attachments: HIVE-1526.2.patch.txt, hive-1526.txt, libfb303.jar, libthrift.jar
>
>
> Hive should depend on a release version of Thrift, and ideally it should use Ivy to resolve this dependency.
> The Thrift folks are working on adding Thrift artifacts to a maven repository here: https://issues.apache.org/jira/browse/THRIFT-363
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1526) Hive should depend on a release
version of Thrift
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12914255#action_12914255 ]
Carl Steinbach commented on HIVE-1526:
--------------------------------------
Sorry, that was a false alarm about the patch. Turns out the github Hive mirror lags the main repo by about a week.
@Todd: This patch introduces unsatisfied dependencies on slf4j-api and slf4j-log4j12. Can you please update the patch to pull these dependencies down with Ivy?
> Hive should depend on a release version of Thrift
> -------------------------------------------------
>
> Key: HIVE-1526
> URL: https://issues.apache.org/jira/browse/HIVE-1526
> Project: Hadoop Hive
> Issue Type: Task
> Components: Build Infrastructure, Clients
> Reporter: Carl Steinbach
> Assignee: Todd Lipcon
> Fix For: 0.6.0, 0.7.0
>
> Attachments: hive-1526.txt, libfb303.jar, libthrift.jar
>
>
> Hive should depend on a release version of Thrift, and ideally it should use Ivy to resolve this dependency.
> The Thrift folks are working on adding Thrift artifacts to a maven repository here: https://issues.apache.org/jira/browse/THRIFT-363
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1526) Hive should depend on a release
version of Thrift
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929777#action_12929777 ]
Carl Steinbach commented on HIVE-1526:
--------------------------------------
@Pradeep: working on it now :)
> Hive should depend on a release version of Thrift
> -------------------------------------------------
>
> Key: HIVE-1526
> URL: https://issues.apache.org/jira/browse/HIVE-1526
> Project: Hive
> Issue Type: Task
> Components: Build Infrastructure, Clients
> Reporter: Carl Steinbach
> Assignee: Todd Lipcon
> Fix For: 0.7.0
>
> Attachments: HIVE-1526.2.patch.txt, hive-1526.txt, libfb303.jar, libthrift.jar
>
>
> Hive should depend on a release version of Thrift, and ideally it should use Ivy to resolve this dependency.
> The Thrift folks are working on adding Thrift artifacts to a maven repository here: https://issues.apache.org/jira/browse/THRIFT-363
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1526) Hive should depend on a release
version of Thrift
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924023#action_12924023 ]
John Sichi commented on HIVE-1526:
----------------------------------
Ning is currently working on some non-Hive tasks, so we'll get someone else to take a look. If you have time after next Monday's contributor meeting, maybe we can do a quick review then in person.
> Hive should depend on a release version of Thrift
> -------------------------------------------------
>
> Key: HIVE-1526
> URL: https://issues.apache.org/jira/browse/HIVE-1526
> Project: Hive
> Issue Type: Task
> Components: Build Infrastructure, Clients
> Reporter: Carl Steinbach
> Assignee: Todd Lipcon
> Fix For: 0.7.0
>
> Attachments: HIVE-1526.2.patch.txt, hive-1526.txt, libfb303.jar, libthrift.jar
>
>
> Hive should depend on a release version of Thrift, and ideally it should use Ivy to resolve this dependency.
> The Thrift folks are working on adding Thrift artifacts to a maven repository here: https://issues.apache.org/jira/browse/THRIFT-363
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1526) Hive should depend on a release
version of Thrift
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923715#action_12923715 ]
Todd Lipcon commented on HIVE-1526:
-----------------------------------
Hey Ning. Can you take a look at this change? It's no longer in sync with trunk, but I don't want to have to redo it twice (it's a pain since you have to regenerate all the files, etc). If the basics look OK I will resync with trunk and then we can commit soonafter.
> Hive should depend on a release version of Thrift
> -------------------------------------------------
>
> Key: HIVE-1526
> URL: https://issues.apache.org/jira/browse/HIVE-1526
> Project: Hive
> Issue Type: Task
> Components: Build Infrastructure, Clients
> Reporter: Carl Steinbach
> Assignee: Todd Lipcon
> Fix For: 0.7.0
>
> Attachments: HIVE-1526.2.patch.txt, hive-1526.txt, libfb303.jar, libthrift.jar
>
>
> Hive should depend on a release version of Thrift, and ideally it should use Ivy to resolve this dependency.
> The Thrift folks are working on adding Thrift artifacts to a maven repository here: https://issues.apache.org/jira/browse/THRIFT-363
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1526) Hive should depend on a release
version of Thrift
Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925018#action_12925018 ]
Pradeep Kamath commented on HIVE-1526:
--------------------------------------
Any update on this? I would like to submit a patch for HIVE-1696 which depends on this and HIVE-842. Since this is currently broken against trunk, am waiting for the new patch (based off thrift-0.5 ?) so I can generate a patch for HIVE-1696.
> Hive should depend on a release version of Thrift
> -------------------------------------------------
>
> Key: HIVE-1526
> URL: https://issues.apache.org/jira/browse/HIVE-1526
> Project: Hive
> Issue Type: Task
> Components: Build Infrastructure, Clients
> Reporter: Carl Steinbach
> Assignee: Todd Lipcon
> Fix For: 0.7.0
>
> Attachments: HIVE-1526.2.patch.txt, hive-1526.txt, libfb303.jar, libthrift.jar
>
>
> Hive should depend on a release version of Thrift, and ideally it should use Ivy to resolve this dependency.
> The Thrift folks are working on adding Thrift artifacts to a maven repository here: https://issues.apache.org/jira/browse/THRIFT-363
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1526) Hive should depend on a release version
of Thrift
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HIVE-1526:
------------------------------
Attachment: hive-1526.txt
libthrift.jar
libfb303.jar
Here is a patch along with the newly built jars from Thrift 0.4.0.
I agree that long term we should make codegen part of the build, but I think it's enough of a hassle to require everyone to install the same version of thrift, we should punt for now.
> Hive should depend on a release version of Thrift
> -------------------------------------------------
>
> Key: HIVE-1526
> URL: https://issues.apache.org/jira/browse/HIVE-1526
> Project: Hadoop Hive
> Issue Type: Task
> Components: Build Infrastructure
> Reporter: Carl Steinbach
> Assignee: Todd Lipcon
> Attachments: hive-1526.txt, libfb303.jar, libthrift.jar
>
>
> Hive should depend on a release version of Thrift, and ideally it should use Ivy to resolve this dependency.
> The Thrift folks are working on adding Thrift artifacts to a maven repository here: https://issues.apache.org/jira/browse/THRIFT-363
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1526) Hive should depend on a release
version of Thrift
Posted by "Ning Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913843#action_12913843 ]
Ning Zhang commented on HIVE-1526:
----------------------------------
The Hive ODBC code is dependent on Thrift as well. In particular the hive client and unixODBC libraries have to be linked with the new libthrift.so. Can you test if the ODBC code is compatible with the new thrift version?
> Hive should depend on a release version of Thrift
> -------------------------------------------------
>
> Key: HIVE-1526
> URL: https://issues.apache.org/jira/browse/HIVE-1526
> Project: Hadoop Hive
> Issue Type: Task
> Components: Build Infrastructure
> Reporter: Carl Steinbach
> Assignee: Todd Lipcon
> Attachments: hive-1526.txt, libfb303.jar, libthrift.jar
>
>
> Hive should depend on a release version of Thrift, and ideally it should use Ivy to resolve this dependency.
> The Thrift folks are working on adding Thrift artifacts to a maven repository here: https://issues.apache.org/jira/browse/THRIFT-363
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1526) Hive should depend on a release
version of Thrift
Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12927549#action_12927549 ]
Pradeep Kamath commented on HIVE-1526:
--------------------------------------
Hi Carl - just wondering if you have had a chance to look at this - a new patch for this issue will help me create a patch for HIVE-1696 (I suspect we will need to redo HIVE-842 as well - I can take a stab at that once this patch is ready).
> Hive should depend on a release version of Thrift
> -------------------------------------------------
>
> Key: HIVE-1526
> URL: https://issues.apache.org/jira/browse/HIVE-1526
> Project: Hive
> Issue Type: Task
> Components: Build Infrastructure, Clients
> Reporter: Carl Steinbach
> Assignee: Todd Lipcon
> Fix For: 0.7.0
>
> Attachments: HIVE-1526.2.patch.txt, hive-1526.txt, libfb303.jar, libthrift.jar
>
>
> Hive should depend on a release version of Thrift, and ideally it should use Ivy to resolve this dependency.
> The Thrift folks are working on adding Thrift artifacts to a maven repository here: https://issues.apache.org/jira/browse/THRIFT-363
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1526) Hive should depend on a release
version of Thrift
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925238#action_12925238 ]
Carl Steinbach commented on HIVE-1526:
--------------------------------------
We discussed this at the contributors meeting yesterday. I'm going to rebase the patch,
modify it to use Thrift 0.5.0, and then make the patch easier to review by removing the
the thrift generated code. I plan to get to this sometime in the next couple of days.
> Hive should depend on a release version of Thrift
> -------------------------------------------------
>
> Key: HIVE-1526
> URL: https://issues.apache.org/jira/browse/HIVE-1526
> Project: Hive
> Issue Type: Task
> Components: Build Infrastructure, Clients
> Reporter: Carl Steinbach
> Assignee: Todd Lipcon
> Fix For: 0.7.0
>
> Attachments: HIVE-1526.2.patch.txt, hive-1526.txt, libfb303.jar, libthrift.jar
>
>
> Hive should depend on a release version of Thrift, and ideally it should use Ivy to resolve this dependency.
> The Thrift folks are working on adding Thrift artifacts to a maven repository here: https://issues.apache.org/jira/browse/THRIFT-363
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1526) Hive should depend on a release version
of Thrift
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1526:
---------------------------------
Attachment: HIVE-1526.2.patch.txt
HIVE-1526.2.patch.txt:
* Manage slf4j dependencies with Ivy.
* Added slf4j dependencies to eclipse classpath.
* Added "thriftif" macro to ${hive.root}/build.xml which triggers recompilation of all thrift stubs.
* Modified odbc/Makefile to use Thrift libs and headers in THRIFT_HOME instead of the ones that were checked into service/include.
* Modified odbc/Makefile to build thrift generated cpp artifacts in ql/src
* Removed thrift headers/code from service/include (HIVE-1527)
* Added some missing #includes to the hiveclient source files in odbc/src/cpp.
Testing:
* Tested eclipse launch configurations.
* Built CPP hiveclient lib and tested against HiveServer using HiveClientTestC program.
> Hive should depend on a release version of Thrift
> -------------------------------------------------
>
> Key: HIVE-1526
> URL: https://issues.apache.org/jira/browse/HIVE-1526
> Project: Hadoop Hive
> Issue Type: Task
> Components: Build Infrastructure, Clients
> Reporter: Carl Steinbach
> Assignee: Todd Lipcon
> Fix For: 0.6.0, 0.7.0
>
> Attachments: HIVE-1526.2.patch.txt, hive-1526.txt, libfb303.jar, libthrift.jar
>
>
> Hive should depend on a release version of Thrift, and ideally it should use Ivy to resolve this dependency.
> The Thrift folks are working on adding Thrift artifacts to a maven repository here: https://issues.apache.org/jira/browse/THRIFT-363
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1526) Hive should depend on a release version
of Thrift
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1526:
---------------------------------
Status: Patch Available (was: Open)
> Hive should depend on a release version of Thrift
> -------------------------------------------------
>
> Key: HIVE-1526
> URL: https://issues.apache.org/jira/browse/HIVE-1526
> Project: Hadoop Hive
> Issue Type: Task
> Components: Build Infrastructure, Clients
> Reporter: Carl Steinbach
> Assignee: Todd Lipcon
> Fix For: 0.6.0, 0.7.0
>
> Attachments: HIVE-1526.2.patch.txt, hive-1526.txt, libfb303.jar, libthrift.jar
>
>
> Hive should depend on a release version of Thrift, and ideally it should use Ivy to resolve this dependency.
> The Thrift folks are working on adding Thrift artifacts to a maven repository here: https://issues.apache.org/jira/browse/THRIFT-363
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1526) Hive should depend on a release version
of Thrift
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1526:
---------------------------------
Fix Version/s: 0.6.0
0.7.0
Component/s: Clients
> Hive should depend on a release version of Thrift
> -------------------------------------------------
>
> Key: HIVE-1526
> URL: https://issues.apache.org/jira/browse/HIVE-1526
> Project: Hadoop Hive
> Issue Type: Task
> Components: Build Infrastructure, Clients
> Reporter: Carl Steinbach
> Assignee: Todd Lipcon
> Fix For: 0.6.0, 0.7.0
>
> Attachments: hive-1526.txt, libfb303.jar, libthrift.jar
>
>
> Hive should depend on a release version of Thrift, and ideally it should use Ivy to resolve this dependency.
> The Thrift folks are working on adding Thrift artifacts to a maven repository here: https://issues.apache.org/jira/browse/THRIFT-363
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1526) Hive should depend on a release
version of Thrift
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913933#action_12913933 ]
Carl Steinbach commented on HIVE-1526:
--------------------------------------
@Todd: Can you please regenerate this patch? Both 'patch -p0' and 'git apply -p0' fail. Thanks.
> Hive should depend on a release version of Thrift
> -------------------------------------------------
>
> Key: HIVE-1526
> URL: https://issues.apache.org/jira/browse/HIVE-1526
> Project: Hadoop Hive
> Issue Type: Task
> Components: Build Infrastructure, Clients
> Reporter: Carl Steinbach
> Assignee: Todd Lipcon
> Fix For: 0.6.0, 0.7.0
>
> Attachments: hive-1526.txt, libfb303.jar, libthrift.jar
>
>
> Hive should depend on a release version of Thrift, and ideally it should use Ivy to resolve this dependency.
> The Thrift folks are working on adding Thrift artifacts to a maven repository here: https://issues.apache.org/jira/browse/THRIFT-363
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1526) Hive should depend on a release
version of Thrift
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12912765#action_12912765 ]
Todd Lipcon commented on HIVE-1526:
-----------------------------------
Planning on upgrading to 0.4.0. The main incompatible changes to deal with:
- Methods that return enums now actually return a java enum type instead of an int (eg fb303's get_status method as well as the operator and stage getType() methods)
- readBinary and writeBinary now use ByteBuffer instead of byte[]
Unfortunately the maven situation is still not yet sorted out. I built a libthrift.jar and a libfb303.jar from the 0.4.0 release tree and will upload them here. Had to fix a minor issue to get fb303 to build (see THRIFT-381)
Aside from that, it seems pretty straightforward. I have a patch, running unit tests now.
> Hive should depend on a release version of Thrift
> -------------------------------------------------
>
> Key: HIVE-1526
> URL: https://issues.apache.org/jira/browse/HIVE-1526
> Project: Hadoop Hive
> Issue Type: Task
> Components: Build Infrastructure
> Reporter: Carl Steinbach
> Assignee: Todd Lipcon
>
> Hive should depend on a release version of Thrift, and ideally it should use Ivy to resolve this dependency.
> The Thrift folks are working on adding Thrift artifacts to a maven repository here: https://issues.apache.org/jira/browse/THRIFT-363
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1526) Hive should depend on a release
version of Thrift
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916751#action_12916751 ]
Carl Steinbach commented on HIVE-1526:
--------------------------------------
@Ning: I removed the 0.6 tag. Can you please review this change? Thanks.
> Hive should depend on a release version of Thrift
> -------------------------------------------------
>
> Key: HIVE-1526
> URL: https://issues.apache.org/jira/browse/HIVE-1526
> Project: Hadoop Hive
> Issue Type: Task
> Components: Build Infrastructure, Clients
> Reporter: Carl Steinbach
> Assignee: Todd Lipcon
> Fix For: 0.7.0
>
> Attachments: HIVE-1526.2.patch.txt, hive-1526.txt, libfb303.jar, libthrift.jar
>
>
> Hive should depend on a release version of Thrift, and ideally it should use Ivy to resolve this dependency.
> The Thrift folks are working on adding Thrift artifacts to a maven repository here: https://issues.apache.org/jira/browse/THRIFT-363
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1526) Hive should depend on a release
version of Thrift
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12914207#action_12914207 ]
Todd Lipcon commented on HIVE-1526:
-----------------------------------
Hi Carl. It appears to apply fine for me on today's trunk:
todd@todd-laptop:~/git/hive$ git reset --hard HEAD
HEAD is now at 08d5e5b HIVE-1661. Default values for parameters (Siying Dong via He Yongqiang)
todd@todd-laptop:~/git/hive$ curl 'https://issues.apache.org/jira/secure/attachment/12455323/hive-1526.txt' | patch -p0
... patch output....
todd@todd-laptop:~/git/hive$
Sure you're up to date on trunk?
> Hive should depend on a release version of Thrift
> -------------------------------------------------
>
> Key: HIVE-1526
> URL: https://issues.apache.org/jira/browse/HIVE-1526
> Project: Hadoop Hive
> Issue Type: Task
> Components: Build Infrastructure, Clients
> Reporter: Carl Steinbach
> Assignee: Todd Lipcon
> Fix For: 0.6.0, 0.7.0
>
> Attachments: hive-1526.txt, libfb303.jar, libthrift.jar
>
>
> Hive should depend on a release version of Thrift, and ideally it should use Ivy to resolve this dependency.
> The Thrift folks are working on adding Thrift artifacts to a maven repository here: https://issues.apache.org/jira/browse/THRIFT-363
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1526) Hive should depend on a release
version of Thrift
Posted by "Ning Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916798#action_12916798 ]
Ning Zhang commented on HIVE-1526:
----------------------------------
I will take a look.
> Hive should depend on a release version of Thrift
> -------------------------------------------------
>
> Key: HIVE-1526
> URL: https://issues.apache.org/jira/browse/HIVE-1526
> Project: Hadoop Hive
> Issue Type: Task
> Components: Build Infrastructure, Clients
> Reporter: Carl Steinbach
> Assignee: Todd Lipcon
> Fix For: 0.7.0
>
> Attachments: HIVE-1526.2.patch.txt, hive-1526.txt, libfb303.jar, libthrift.jar
>
>
> Hive should depend on a release version of Thrift, and ideally it should use Ivy to resolve this dependency.
> The Thrift folks are working on adding Thrift artifacts to a maven repository here: https://issues.apache.org/jira/browse/THRIFT-363
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1526) Hive should depend on a release
version of Thrift
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12927081#action_12927081 ]
Carl Steinbach commented on HIVE-1526:
--------------------------------------
Need to update this page once this change is committed: http://wiki.apache.org/hadoop/Hive/HowToContribute#Generating_Code
> Hive should depend on a release version of Thrift
> -------------------------------------------------
>
> Key: HIVE-1526
> URL: https://issues.apache.org/jira/browse/HIVE-1526
> Project: Hive
> Issue Type: Task
> Components: Build Infrastructure, Clients
> Reporter: Carl Steinbach
> Assignee: Todd Lipcon
> Fix For: 0.7.0
>
> Attachments: HIVE-1526.2.patch.txt, hive-1526.txt, libfb303.jar, libthrift.jar
>
>
> Hive should depend on a release version of Thrift, and ideally it should use Ivy to resolve this dependency.
> The Thrift folks are working on adding Thrift artifacts to a maven repository here: https://issues.apache.org/jira/browse/THRIFT-363
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HIVE-1526) Hive should depend on a release
version of Thrift
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon reassigned HIVE-1526:
---------------------------------
Assignee: Todd Lipcon
> Hive should depend on a release version of Thrift
> -------------------------------------------------
>
> Key: HIVE-1526
> URL: https://issues.apache.org/jira/browse/HIVE-1526
> Project: Hadoop Hive
> Issue Type: Task
> Components: Build Infrastructure
> Reporter: Carl Steinbach
> Assignee: Todd Lipcon
>
> Hive should depend on a release version of Thrift, and ideally it should use Ivy to resolve this dependency.
> The Thrift folks are working on adding Thrift artifacts to a maven repository here: https://issues.apache.org/jira/browse/THRIFT-363
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1526) Hive should depend on a release
version of Thrift
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12912768#action_12912768 ]
Todd Lipcon commented on HIVE-1526:
-----------------------------------
Er, sorry, not THRIFT-381, but rather THRIFT-907. Too many browser tabs!
> Hive should depend on a release version of Thrift
> -------------------------------------------------
>
> Key: HIVE-1526
> URL: https://issues.apache.org/jira/browse/HIVE-1526
> Project: Hadoop Hive
> Issue Type: Task
> Components: Build Infrastructure
> Reporter: Carl Steinbach
> Assignee: Todd Lipcon
>
> Hive should depend on a release version of Thrift, and ideally it should use Ivy to resolve this dependency.
> The Thrift folks are working on adding Thrift artifacts to a maven repository here: https://issues.apache.org/jira/browse/THRIFT-363
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1526) Hive should depend on a release
version of Thrift
Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929632#action_12929632 ]
Pradeep Kamath commented on HIVE-1526:
--------------------------------------
Hi Carl - just wondering if you have had a chance to look at this..
> Hive should depend on a release version of Thrift
> -------------------------------------------------
>
> Key: HIVE-1526
> URL: https://issues.apache.org/jira/browse/HIVE-1526
> Project: Hive
> Issue Type: Task
> Components: Build Infrastructure, Clients
> Reporter: Carl Steinbach
> Assignee: Todd Lipcon
> Fix For: 0.7.0
>
> Attachments: HIVE-1526.2.patch.txt, hive-1526.txt, libfb303.jar, libthrift.jar
>
>
> Hive should depend on a release version of Thrift, and ideally it should use Ivy to resolve this dependency.
> The Thrift folks are working on adding Thrift artifacts to a maven repository here: https://issues.apache.org/jira/browse/THRIFT-363
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1526) Hive should depend on a release
version of Thrift
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924065#action_12924065 ]
Carl Steinbach commented on HIVE-1526:
--------------------------------------
I'll be at the contributors meeting. John, if you have time lets meet afterwards to
review this patch.
> Hive should depend on a release version of Thrift
> -------------------------------------------------
>
> Key: HIVE-1526
> URL: https://issues.apache.org/jira/browse/HIVE-1526
> Project: Hive
> Issue Type: Task
> Components: Build Infrastructure, Clients
> Reporter: Carl Steinbach
> Assignee: Todd Lipcon
> Fix For: 0.7.0
>
> Attachments: HIVE-1526.2.patch.txt, hive-1526.txt, libfb303.jar, libthrift.jar
>
>
> Hive should depend on a release version of Thrift, and ideally it should use Ivy to resolve this dependency.
> The Thrift folks are working on adding Thrift artifacts to a maven repository here: https://issues.apache.org/jira/browse/THRIFT-363
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1526) Hive should depend on a release
version of Thrift
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924036#action_12924036 ]
Todd Lipcon commented on HIVE-1526:
-----------------------------------
Hey John. I'm actually headed to Tokyo for the next two weeks so won't be at the contributors meeting. Perhaps Carl can look at this with you. Note that we should update the change to Thrift 0.5.0 release before committing, but the review can happen on current code.
> Hive should depend on a release version of Thrift
> -------------------------------------------------
>
> Key: HIVE-1526
> URL: https://issues.apache.org/jira/browse/HIVE-1526
> Project: Hive
> Issue Type: Task
> Components: Build Infrastructure, Clients
> Reporter: Carl Steinbach
> Assignee: Todd Lipcon
> Fix For: 0.7.0
>
> Attachments: HIVE-1526.2.patch.txt, hive-1526.txt, libfb303.jar, libthrift.jar
>
>
> Hive should depend on a release version of Thrift, and ideally it should use Ivy to resolve this dependency.
> The Thrift folks are working on adding Thrift artifacts to a maven repository here: https://issues.apache.org/jira/browse/THRIFT-363
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1526) Hive should depend on a release version
of Thrift
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1526:
---------------------------------
Fix Version/s: (was: 0.6.0)
> Hive should depend on a release version of Thrift
> -------------------------------------------------
>
> Key: HIVE-1526
> URL: https://issues.apache.org/jira/browse/HIVE-1526
> Project: Hadoop Hive
> Issue Type: Task
> Components: Build Infrastructure, Clients
> Reporter: Carl Steinbach
> Assignee: Todd Lipcon
> Fix For: 0.7.0
>
> Attachments: HIVE-1526.2.patch.txt, hive-1526.txt, libfb303.jar, libthrift.jar
>
>
> Hive should depend on a release version of Thrift, and ideally it should use Ivy to resolve this dependency.
> The Thrift folks are working on adding Thrift artifacts to a maven repository here: https://issues.apache.org/jira/browse/THRIFT-363
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.