You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "zeroshade (via GitHub)" <gi...@apache.org> on 2025/02/18 20:49:45 UTC
[PR] docs(license): update LICENSE.txt [arrow-go]
zeroshade opened a new pull request, #290:
URL: https://github.com/apache/arrow-go/pull/290
### Rationale for this change
Fixes #275
### What changes are included in this PR?
Removing "safe-math" from being vendored as it's no longer being used. Updating the LICENSE.txt with all appropriate information including files which contain code that has been copied from other projects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(license): update LICENSE.txt [arrow-go]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #290:
URL: https://github.com/apache/arrow-go/pull/290#issuecomment-2667653308
Thanks ! As you removed safe-math, the `LICENSE` doesn't have to be updated.
About the code copied from LLVM, it's OK in the `LICENSE` and no need to update `NOTICE` as LLVM doesn't provide a `NOTICE`.
The dependency copyright doesn't have to be in `NOTICE` (`NOTICE` is to host relevant information from dependency `NOTICE`).
The copyright should be in `LICENSE` with the code copied (similar to https://github.com/apache/arrow-java/blob/main/LICENSE.txt#L211).
On the other hand, the project copyright should be in the `NOTICE`, and we are good here:
```
Apache Arrow Go
Copyright 2016-2025 The Apache Software Foundation
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
```
So, @zeroshade you are good here ! Thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(license): update LICENSE.txt [arrow-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #290:
URL: https://github.com/apache/arrow-go/pull/290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(license): update LICENSE.txt [arrow-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #290:
URL: https://github.com/apache/arrow-go/pull/290#issuecomment-2666928196
The `NOTICE.txt` file contains the line `Copyright 2016-2025 The Apache Software Foundation` and the heading of every source file has the standard Apache License which includes `See the NOTICE file distributed with this work for additional information regarding copyright ownership.`
Is that sufficient?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(license): update LICENSE.txt [arrow-go]
Posted by "jas4711 (via GitHub)" <gi...@apache.org>.
jas4711 commented on PR #290:
URL: https://github.com/apache/arrow-go/pull/290#issuecomment-2666920878
Thank you! Looks good to me, even though it does not add any copyright notices for ASF. I was expecting something like:
```
Copyright (C) Apache Software Foundation
```
Is there any reason you do not want this to be in the git repo? I don't care strongly about legal reasons here, but there is a lot of license scanners that search for 'Copyright' as a string to find licenses and authors. It would have saved me some uncertainty when trying to figure out Debian's debian/copyright file for this package if there were more clear copyright notices pointing at the ASF. Sometimes the exact legal name is significant too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(license): update LICENSE.txt [arrow-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #290:
URL: https://github.com/apache/arrow-go/pull/290#issuecomment-2666903282
CC @jbonofre @jas4711
Please take a look and confirm if I missed anything, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org