You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "eugenegujing (via GitHub)" <gi...@apache.org> on 2026/07/18 08:50:55 UTC

Re: [PR] test(pyamber): add unit test coverage for InputManager [texera]

eugenegujing commented on PR #6491:
URL: https://github.com/apache/texera/pull/6491#issuecomment-5010647848

   > #### ๐Ÿค– texera-dev review
   > ๐Ÿšฆ **1 must-fix ยท 0 advisory ยท 0 polish** โ€” requesting changes only on the commit scope; the test code itself is a clean characterization suite.
   > 
   > ### ๐Ÿ“ Title & commit scope (1)
   > * ๐Ÿ”ด **must-fix** โ€” retitle `test(amber)` โ†’ `test(pyamber): add unit test coverage for InputManager`. The PR title becomes the squash-merge commit message, and the tested code is the Python worker engine (`pyamber`), not the Scala engine (`amber`). AGENTS.md scopes the Python engine `pyamber` (its test example is `test(pyamber): โ€ฆ`), the `pyamber` codecov flag moved (+0.54%, not `amber`), and the near-identical merged PR is `test(pyamber): add unit test coverage for InternalQueue`.
   
   @Yicong-Huang fixed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org