You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/05/31 02:35:11 UTC
[GitHub] [rocketmq] RealBar opened a new pull request #2058: fix: fix issue#2055
RealBar opened a new pull request #2058:
URL: https://github.com/apache/rocketmq/pull/2058
## What is the purpose of the change
fix issue 2055
https://github.com/apache/rocketmq/issues/2055#issue-627309782
## Brief changelog
add null pointer check before implicit conversion
## Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] duhenglucky merged pull request #2058: [ISSUE #2055] Fix NPE in SendMessageProcessor.handleRetryAndDLQ
Posted by GitBox <gi...@apache.org>.
duhenglucky merged pull request #2058:
URL: https://github.com/apache/rocketmq/pull/2058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on pull request #2058: [ISSUE #2055] Fix NPE in SendMessageProcessor.handleRetryAndDLQ
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on pull request #2058:
URL: https://github.com/apache/rocketmq/pull/2058#issuecomment-738624419
@RealBar The code must be passed by CI. Could you fix the code format issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on pull request #2058: [ISSUE #2055] Fix NPE in SendMessageProcessor.handleRetryAndDLQ
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on pull request #2058:
URL: https://github.com/apache/rocketmq/pull/2058#issuecomment-740443793
@RealBar Your code is correct, but it must pass CI, otherwise it cannot be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] xiangwangcheng commented on pull request #2058: [ISSUE#2055] Fix NPE in SendMessageProcessor.handleRetryAndDLQ
Posted by GitBox <gi...@apache.org>.
xiangwangcheng commented on pull request #2058:
URL: https://github.com/apache/rocketmq/pull/2058#issuecomment-645787534
@RealBar
Seems there is a code format problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #2058: [ISSUE #2055] Fix NPE in SendMessageProcessor.handleRetryAndDLQ
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2058:
URL: https://github.com/apache/rocketmq/pull/2058#issuecomment-884227157
[](https://coveralls.io/builds/41532576)
Coverage decreased (-0.1%) to 54.028% when pulling **74aa3e005689e2d46c1a7d6ebb9041930132b141 on RealBar:fix/issue2055** into **93974b0dd542c9f478aa8da65909b86ae7de0ca6 on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on pull request #2058: [ISSUE#2055] Fix NPE in SendMessageProcessor.handleRetryAndDLQ
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on pull request #2058:
URL: https://github.com/apache/rocketmq/pull/2058#issuecomment-636626163
Hi, @RealBar You need change the target branch to develop and pass the CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org