You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/12/02 15:27:12 UTC
[GitHub] [beam] Abacn opened a new pull request, #24492: [release-2.43.0] Cherry-pick: Revert 23969 sqlttypes
Abacn opened a new pull request, #24492:
URL: https://github.com/apache/beam/pull/24492
**Please** add a meaningful description for your change here
Cherry pick #24489 into release-2.44.0 branch.
Justification: #23969 introduced a regression in 2.44.0. It introduces SqlType.TIMESTAMP (micros_instant) logical type when converting from avro logical type TimestampMicros, but this Beam portable logical type is not yet supported in Beam SQL. Similar regression may occur other than Beam SQL where micros_instant is not supported.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #24492: [release-2.44.0] Cherry-pick: Revert 23969 sqlttypes
Posted by GitBox <gi...@apache.org>.
kennknowles commented on PR #24492:
URL: https://github.com/apache/beam/pull/24492#issuecomment-1335573855
LGTM and I will merge once it is green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #24492: [release-2.44.0] Cherry-pick: Revert 23969 sqlttypes
Posted by GitBox <gi...@apache.org>.
kennknowles commented on PR #24492:
URL: https://github.com/apache/beam/pull/24492#issuecomment-1338005999
it was a pulsar flake, but I have time to kick it again to get green
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #24492: [release-2.44.0] Cherry-pick: Revert 23969 sqlttypes
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #24492:
URL: https://github.com/apache/beam/pull/24492#issuecomment-1339614062
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #24492: [release-2.44.0] Cherry-pick: Revert 23969 sqlttypes
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #24492:
URL: https://github.com/apache/beam/pull/24492#issuecomment-1340282519
This time is `org.apache.beam.runners.samza.runtime.AsyncDoFnRunnerTest.testPipelineWithState` (related to #23745, another sazma runner test)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #24492: [release-2.44.0] Cherry-pick: Revert 23969 sqlttypes
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #24492:
URL: https://github.com/apache/beam/pull/24492#issuecomment-1335727252
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles merged pull request #24492: [release-2.44.0] Cherry-pick: Revert 23969 sqlttypes
Posted by GitBox <gi...@apache.org>.
kennknowles merged PR #24492:
URL: https://github.com/apache/beam/pull/24492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #24492: [release-2.43.0] Cherry-pick: Revert 23969 sqlttypes
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #24492:
URL: https://github.com/apache/beam/pull/24492#issuecomment-1335424324
R: @kennknowles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #24492: [release-2.44.0] Cherry-pick: Revert 23969 sqlttypes
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #24492:
URL: https://github.com/apache/beam/pull/24492#issuecomment-1335730148
changes on sdk.core often makes the first run of precommit timeout as gradle cache is not used and it tries to re-compile all codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #24492: [release-2.43.0] Cherry-pick: Revert 23969 sqlttypes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24492:
URL: https://github.com/apache/beam/pull/24492#issuecomment-1335426014
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #24492: [release-2.44.0] Cherry-pick: Revert 23969 sqlttypes
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #24492:
URL: https://github.com/apache/beam/pull/24492#issuecomment-1335936376
Tests actually ended. Java Precommit fail `org.apache.beam.sdk.io.pulsar.PulsarIOTest.testReadFromSimpleTopic` known flake, the other two are succeeded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #24492: [release-2.44.0] Cherry-pick: Revert 23969 sqlttypes
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #24492:
URL: https://github.com/apache/beam/pull/24492#issuecomment-1338003422
Just a reminder (don't want this PR to block the release) @kennknowles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #24492: [release-2.44.0] Cherry-pick: Revert 23969 sqlttypes
Posted by GitBox <gi...@apache.org>.
kennknowles commented on PR #24492:
URL: https://github.com/apache/beam/pull/24492#issuecomment-1338005747
run java precommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #24492: [release-2.44.0] Cherry-pick: Revert 23969 sqlttypes
Posted by GitBox <gi...@apache.org>.
kennknowles commented on PR #24492:
URL: https://github.com/apache/beam/pull/24492#issuecomment-1343058202
OK I am going to merge anyhow. That test is disabled on master now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org