[GitHub] [gobblin] aplex commented on a change in pull request #3330: [GOBBLIN-1489] define some configs

[GitBox <gi...@apache.org>]

aplex commented on a change in pull request #3330:
URL: https://github.com/apache/gobblin/pull/3330#discussion_r669872119



##########
File path: gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java
##########
@@ -969,6 +970,7 @@
   public static final Charset DEFAULT_CHARSET_ENCODING = Charsets.UTF_8;
   public static final String TEST_HARNESS_LAUNCHER_IMPL = "gobblin.testharness.launcher.impl";
   public static final int PERMISSION_PARSING_RADIX = 8;
+  public static final String NON_TRANSIENT_ERROR_MESSAGES = "non.transient.error.messages";

Review comment:
       Is this a new setting, or this property comes from the external system?
   
   If it's a new one, I suggest to prefix it with "gobblin." , and consider a more descriptive name. Thing separate by dots usually mean class/property names. So in this case there will be class "non", class "transient", "error" and it will have a property "message". Something like "gobblin.errorMessages.logNonTransientErrors" could be more meaningful




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org