[GitHub] [bigtop] guyuqi commented on issue #555: BIGTOP-3264: Add a new Bigtop Mpack definition for Ambari

[GitBox <gi...@apache.org>]

guyuqi commented on issue #555: BIGTOP-3264: Add a new Bigtop Mpack definition for Ambari
URL: https://github.com/apache/bigtop/pull/555#issuecomment-599397759
 
 
   
   
   > @guyuqi Thanks for the video and instructions. Those are very informative. So it seems that the the url need to be updated and II need to rebuild the amber packages w/ the patch, correct?
   > 
   > When building, I'm running into another error, which wasn't there previously. Probably another 3rd party dependency issue.
   > https://ci.bigtop.apache.org/view/Test/job/Build-Deploy-Smoke-Test-Pull-Request-Single-Distro/14/console
   > Let me try to get around this.
   > 
   > In the meantime, I've looked into the PR again. I've concern on how ODPi's mpack work. It seems the JAR/binary is contained in the patch file, making the patch 20MB large.
   > Can we get ride of this? Why the jars need to be included instead of fetched and packaged?
   
   @evans-ye  really sry for the late response.
   
   For ODPi Mpack has been included in Ambari trunk, it just added some build and deploying srcripts in bigtop to make itself work. But the ODPi Mpack doesn't work now and no guys would maintain it.
   
   For the BGTP Mpack in this PR, it has not been merged in Ambari.
   So the [PR #3073](https://github.com/apache/ambari/pull/3073) was proposed and `patch3-AMBARI-MPACK.diff` is used as the mirror-file for  [PR #3073](https://github.com/apache/ambari/pull/3073) .
   
   `patch3-AMBARI-MPACK.diff` composed of 158 files including Json, py and other scripts. 
   Firstly we retain this mirror-file to make BGTP mpack work in Bigtop and we will remove this mirror-file when [PR #3073](https://github.com/apache/ambari/pull/3073) is merged. 
   WDYT? 
   Thanks!
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services