You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/07/20 22:30:29 UTC
[GitHub] [incubator-druid] clintropolis commented on a change in pull
request #8116: remove unnecessary lock in ForegroundCachePopulator leading
to a lot of contention
clintropolis commented on a change in pull request #8116: remove unnecessary lock in ForegroundCachePopulator leading to a lot of contention
URL: https://github.com/apache/incubator-druid/pull/8116#discussion_r305595471
##########
File path: server/src/main/java/org/apache/druid/client/cache/ForegroundCachePopulator.java
##########
@@ -76,20 +75,18 @@ public ForegroundCachePopulator(
sequence,
input -> {
if (!tooBig.get()) {
Review comment:
Oops good catch, yeah this is probably not required, will change :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org