You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by ol...@apache.org on 2011/07/06 13:02:26 UTC
svn commit: r1143338 -
/maven/archetype/trunk/archetype-common/src/main/java/org/apache/maven/archetype/common/DefaultArchetypeArtifactManager.java
Author: olamy
Date: Wed Jul 6 11:02:26 2011
New Revision: 1143338
URL: http://svn.apache.org/viewvc?rev=1143338&view=rev
Log:
take care of NPE : thanks sonar
Modified:
maven/archetype/trunk/archetype-common/src/main/java/org/apache/maven/archetype/common/DefaultArchetypeArtifactManager.java
Modified: maven/archetype/trunk/archetype-common/src/main/java/org/apache/maven/archetype/common/DefaultArchetypeArtifactManager.java
URL: http://svn.apache.org/viewvc/maven/archetype/trunk/archetype-common/src/main/java/org/apache/maven/archetype/common/DefaultArchetypeArtifactManager.java?rev=1143338&r1=1143337&r2=1143338&view=diff
==============================================================================
--- maven/archetype/trunk/archetype-common/src/main/java/org/apache/maven/archetype/common/DefaultArchetypeArtifactManager.java (original)
+++ maven/archetype/trunk/archetype-common/src/main/java/org/apache/maven/archetype/common/DefaultArchetypeArtifactManager.java Wed Jul 6 11:02:26 2011
@@ -485,7 +485,10 @@ public class DefaultArchetypeArtifactMan
}
finally
{
- reader.close();
+ if (reader != null)
+ {
+ reader.close();
+ }
}
}
Re: svn commit: r1143338 - /maven/archetype/trunk/archetype-common/src/main/java/org/apache/maven/archetype/common/DefaultArchetypeArtifactManager.java
Posted by Hervé BOUTEMY <he...@free.fr>.
yes, thanks Sonar
but doesn't Sonar ask for a try/catch when in a finally block?
Why we finally use IOUtil(s).close(Quietly) to do the full pattern?
:)
Regards,
Hervé
Le mercredi 6 juillet 2011, olamy@apache.org a écrit :
> Author: olamy
> Date: Wed Jul 6 11:02:26 2011
> New Revision: 1143338
>
> URL: http://svn.apache.org/viewvc?rev=1143338&view=rev
> Log:
> take care of NPE : thanks sonar
>
> Modified:
>
> maven/archetype/trunk/archetype-common/src/main/java/org/apache/maven/arch
> etype/common/DefaultArchetypeArtifactManager.java
>
> Modified:
> maven/archetype/trunk/archetype-common/src/main/java/org/apache/maven/arch
> etype/common/DefaultArchetypeArtifactManager.java URL:
> http://svn.apache.org/viewvc/maven/archetype/trunk/archetype-common/src/ma
> in/java/org/apache/maven/archetype/common/DefaultArchetypeArtifactManager.j
> ava?rev=1143338&r1=1143337&r2=1143338&view=diff
> ==========================================================================
> ==== ---
> maven/archetype/trunk/archetype-common/src/main/java/org/apache/maven/arch
> etype/common/DefaultArchetypeArtifactManager.java (original) +++
> maven/archetype/trunk/archetype-common/src/main/java/org/apache/maven/arch
> etype/common/DefaultArchetypeArtifactManager.java Wed Jul 6 11:02:26 2011
> @@ -485,7 +485,10 @@ public class DefaultArchetypeArtifactMan
> }
> finally
> {
> - reader.close();
> + if (reader != null)
> + {
> + reader.close();
> + }
> }
> }
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org