You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/10 11:49:14 UTC

[GitHub] [apisix-dashboard] okaybase opened a new pull request #1972: Okaybase

okaybase opened a new pull request #1972:
URL: https://github.com/apache/apisix-dashboard/pull/1972


   Please answer these questions before submitting a pull request, **or your PR will get closed**.
   
   **Why submit this pull request?**
   Modify some txt tips to correct grammar.
   
   - [ ] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [x] Improve document
   - [ ] Backport patches
   
   **What changes will this PR take into?**
   
   Please update this section with detailed description.
   
   **Related issues**
   
   fix/resolve #Modify some txt tips to correct grammar.
   
   **Checklist:**
   
   - [x] Did you explain what problem does this PR solve? Or what new features have been added?
   - [ ] Have you added corresponding test cases?
   - [x] Have you modified the corresponding document?
   - [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] gxthrj merged pull request #1972: docs: modify some txt tips to correct grammar

Posted by GitBox <gi...@apache.org>.
gxthrj merged pull request #1972:
URL: https://github.com/apache/apisix-dashboard/pull/1972


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1972: Okaybase

Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #1972:
URL: https://github.com/apache/apisix-dashboard/pull/1972#issuecomment-877625013


   :construction_worker: Deploy Preview for *apisix-dashboard* processing.
   
   
   :hammer: Explore the source changes: 52e0da810ff189e1a25f77b68be6759ecce3b054
   
   :mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60e98931e904c600075edbac](https://app.netlify.com/sites/apisix-dashboard/deploys/60e98931e904c600075edbac?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1972: docs: modify some txt tips to correct grammar

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1972:
URL: https://github.com/apache/apisix-dashboard/pull/1972#issuecomment-877766669


   you can cc @liuxiran @LiteSun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1972: docs: modify some txt tips to correct grammar

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1972:
URL: https://github.com/apache/apisix-dashboard/pull/1972#issuecomment-877746946


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1972?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1972](https://codecov.io/gh/apache/apisix-dashboard/pull/1972?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (52e0da8) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/94b1a1681afc382de35bb116b397d284670b3b87?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (94b1a16) will **decrease** coverage by `2.78%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1972/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/1972?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1972      +/-   ##
   ==========================================
   - Coverage   66.79%   64.01%   -2.79%     
   ==========================================
     Files         182      122      -60     
     Lines        6575     3154    -3421     
     Branches      753      753              
   ==========================================
   - Hits         4392     2019    -2373     
   + Misses       1907     1135     -772     
   + Partials      276        0     -276     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `64.01% <ø> (+0.06%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1972?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [web/src/components/Plugin/PluginPage.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1972/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5QYWdlLnRzeA==) | `98.70% <ø> (ø)` | |
   | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1972/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | | |
   | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1972/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | | |
   | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1972/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | | |
   | [.../internal/handler/authentication/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1972/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvYXV0aGVudGljYXRpb24vYXV0aGVudGljYXRpb24uZ28=) | | |
   | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1972/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | | |
   | [api/internal/log/zap.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1972/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2xvZy96YXAuZ28=) | | |
   | [api/internal/filter/recover.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1972/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZWNvdmVyLmdv) | | |
   | [api/cmd/install.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1972/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9pbnN0YWxsLmdv) | | |
   | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1972/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | | |
   | ... and [52 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1972/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1972?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1972?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [94b1a16...52e0da8](https://codecov.io/gh/apache/apisix-dashboard/pull/1972?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] okaybase commented on pull request #1972: docs: modify some txt tips to correct grammar

Posted by GitBox <gi...@apache.org>.
okaybase commented on pull request #1972:
URL: https://github.com/apache/apisix-dashboard/pull/1972#issuecomment-877769979


   Okay, thanks for your tip! @iamayushdas :smile:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] okaybase commented on pull request #1972: docs: modify some txt tips to correct grammar

Posted by GitBox <gi...@apache.org>.
okaybase commented on pull request #1972:
URL: https://github.com/apache/apisix-dashboard/pull/1972#issuecomment-877753475


   Thanks for your review. @iamayushdas @juzhiyuan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1972: docs: modify some txt tips to correct grammar

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1972:
URL: https://github.com/apache/apisix-dashboard/pull/1972#issuecomment-877625013


   :heavy_check_mark: Deploy Preview for *apisix-dashboard* ready!
   
   
   :hammer: Explore the source changes: 52e0da810ff189e1a25f77b68be6759ecce3b054
   
   :mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60e98931e904c600075edbac](https://app.netlify.com/sites/apisix-dashboard/deploys/60e98931e904c600075edbac?utm_source=github&utm_campaign=bot_dl)
   
   :sunglasses: Browse the preview: [https://deploy-preview-1972--apisix-dashboard.netlify.app/](https://deploy-preview-1972--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org