You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2020/03/02 18:39:41 UTC
[GitHub] [tomcat] bohmber opened a new pull request #249: Support for
default values in property value expressions
bohmber opened a new pull request #249: Support for default values in property value expressions
URL: https://github.com/apache/tomcat/pull/249
It would be nice to have support for default values in property value expressions.
You can use it with ${key:default}.
Any interest in this feature?
Where is the best place for document this?
Where to add a junit test for this?
I used a modified version of
org.apache.catalina.startup.TestTomcatStandalone on my local env.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] bohmber commented on issue #249: Support for default
values in property value expressions
Posted by GitBox <gi...@apache.org>.
bohmber commented on issue #249: Support for default values in property value expressions
URL: https://github.com/apache/tomcat/pull/249#issuecomment-606486744
Ping. Anything else needed for this pr?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] bohmber commented on issue #249: Support for default
values in property value expressions
Posted by GitBox <gi...@apache.org>.
bohmber commented on issue #249: Support for default values in property value expressions
URL: https://github.com/apache/tomcat/pull/249#issuecomment-596587712
Unit test would be good. Did you have a good idea for a starting point for an unit test? I was playing with `TestTomcatStandalone`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] martin-g commented on issue #249: Support for default
values in property value expressions
Posted by GitBox <gi...@apache.org>.
martin-g commented on issue #249: Support for default values in property value expressions
URL: https://github.com/apache/tomcat/pull/249#issuecomment-596737473
> Added a simple unit test.
Awesome!
Just one more thing: please update the javadoc of the `public` method that it supports default value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] bohmber commented on issue #249: Support for default
values in property value expressions
Posted by GitBox <gi...@apache.org>.
bohmber commented on issue #249: Support for default values in property value expressions
URL: https://github.com/apache/tomcat/pull/249#issuecomment-596735064
Added a simple unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] martin-g commented on issue #249: Support for default
values in property value expressions
Posted by GitBox <gi...@apache.org>.
martin-g commented on issue #249: Support for default values in property value expressions
URL: https://github.com/apache/tomcat/pull/249#issuecomment-596489855
The change looks good to me but it would be nice to have some new unit tests for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on issue #249: Support for default
values in property value expressions
Posted by GitBox <gi...@apache.org>.
markt-asf commented on issue #249: Support for default values in property value expressions
URL: https://github.com/apache/tomcat/pull/249#issuecomment-593566006
Hmm. That makes ":" a reserved character in property values. That is going to have an impact on backwards compatibility. ":" is likely to be used for the address attribute for IPv6 addresses. I think it is going to be tricky to find a suitable character to use as a delimiter here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] martin-g commented on issue #249: Support for default
values in property value expressions
Posted by GitBox <gi...@apache.org>.
martin-g commented on issue #249: Support for default values in property value expressions
URL: https://github.com/apache/tomcat/pull/249#issuecomment-596617039
No need to start Tomcat. Just plain old unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf closed pull request #249: Support for default
values in property value expressions
Posted by GitBox <gi...@apache.org>.
markt-asf closed pull request #249: Support for default values in property value expressions
URL: https://github.com/apache/tomcat/pull/249
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on issue #249: Support for default
values in property value expressions
Posted by GitBox <gi...@apache.org>.
markt-asf commented on issue #249: Support for default values in property value expressions
URL: https://github.com/apache/tomcat/pull/249#issuecomment-593575547
Of course, this is the name, not the value and if the name with ":" is tried first that should be fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] bohmber commented on issue #249: Support for default
values in property value expressions
Posted by GitBox <gi...@apache.org>.
bohmber commented on issue #249: Support for default values in property value expressions
URL: https://github.com/apache/tomcat/pull/249#issuecomment-606492623
Thanks that is fine for me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] bohmber commented on issue #249: Support for default
values in property value expressions
Posted by GitBox <gi...@apache.org>.
bohmber commented on issue #249: Support for default values in property value expressions
URL: https://github.com/apache/tomcat/pull/249#issuecomment-593574531
I try to resolve the property with ":" first. Can you give me some examples of what goes wrong. I don't want i introduce something that is not backwards compatible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on issue #249: Support for default
values in property value expressions
Posted by GitBox <gi...@apache.org>.
markt-asf commented on issue #249: Support for default values in property value expressions
URL: https://github.com/apache/tomcat/pull/249#issuecomment-606489783
Nothing comes to mind immediately. We typically go through all the open PRs before we start the release process. We aim to start the release process at the beginning of the month so we'll be going through the PRs in the next day or so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on issue #249: Support for default
values in property value expressions
Posted by GitBox <gi...@apache.org>.
markt-asf commented on issue #249: Support for default values in property value expressions
URL: https://github.com/apache/tomcat/pull/249#issuecomment-607903803
Thanks for thr PR. A variation has been applied to all currently supported branches.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org