You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Enis Soztutar (JIRA)" <ji...@apache.org> on 2013/03/19 18:41:17 UTC

[jira] [Commented] (HBASE-8129) Enhance long line detection in patch testing by ignoring generated files

    [ https://issues.apache.org/jira/browse/HBASE-8129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606573#comment-13606573 ] 

Enis Soztutar commented on HBASE-8129:
--------------------------------------

line length detection is a hack quickly put together because we do not have smt like checkstyle. We should use a proper tool. 
                
> Enhance long line detection in patch testing by ignoring generated files
> ------------------------------------------------------------------------
>
>                 Key: HBASE-8129
>                 URL: https://issues.apache.org/jira/browse/HBASE-8129
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>
> Currently test-patch.sh doesn't distinguish long line in developer written code and code in generated files (from .proto files, e.g.)
> We can enhance long line detection by excluding generated files.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira