You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/07/10 21:05:41 UTC
[kudu-CR] Fix KuduScanTokenBuilder::SetDiffScan docs
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13837
Change subject: Fix KuduScanTokenBuilder::SetDiffScan docs
......................................................................
Fix KuduScanTokenBuilder::SetDiffScan docs
It looks like Doxygen can’t use `@copydoc` when
the doc being copied is in a `@cond PRIVATE_API`.
Change-Id: I448c00b78f9d14685e87d154e1bbee0eaa8e8e24
---
M src/kudu/client/client.h
1 file changed, 18 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/13837/1
--
To view, visit http://gerrit.cloudera.org:8080/13837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I448c00b78f9d14685e87d154e1bbee0eaa8e8e24
Gerrit-Change-Number: 13837
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] Fix KuduScanTokenBuilder::SetDiffScan docs
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13837 )
Change subject: Fix KuduScanTokenBuilder::SetDiffScan docs
......................................................................
Fix KuduScanTokenBuilder::SetDiffScan docs
It looks like Doxygen can’t use `@copydoc` when
the doc being copied is in a `@cond PRIVATE_API`.
Change-Id: I448c00b78f9d14685e87d154e1bbee0eaa8e8e24
Reviewed-on: http://gerrit.cloudera.org:8080/13837
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/client/client.h
1 file changed, 18 insertions(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I448c00b78f9d14685e87d154e1bbee0eaa8e8e24
Gerrit-Change-Number: 13837
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Fix KuduScanTokenBuilder::SetDiffScan docs
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13837 )
Change subject: Fix KuduScanTokenBuilder::SetDiffScan docs
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13837/2/src/kudu/client/client.h
File src/kudu/client/client.h:
http://gerrit.cloudera.org:8080/#/c/13837/2/src/kudu/client/client.h@2436
PS2, Line 2436: /// Set the start and end timestamp for a diff scan. The timestamps should be
: /// encoded HT timestamps.
: ///
: /// Additionally sets any other scan properties required by diff scans.
: ///
: /// Private API.
: ///
: /// @param [in] start_timestamp
: /// Start timestamp to set in raw encoded form
: /// (i.e. as returned by a previous call to a server).
: /// @param [in] end_timestamp
: /// End timestamp to set in raw encoded form
: /// (i.e. as returned by a previous call to a server).
: /// @return Operation result status.
nit: given this update puts the KuduScanTokenBuilder::SetDiffScan into the priviate API section, the easier way would be just adding the @cond/@endcond since the source of the reference is under the same conditional.
I'll put up a patch to address this.
--
To view, visit http://gerrit.cloudera.org:8080/13837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I448c00b78f9d14685e87d154e1bbee0eaa8e8e24
Gerrit-Change-Number: 13837
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 10 Jul 2019 23:48:24 +0000
Gerrit-HasComments: Yes
[kudu-CR] Fix KuduScanTokenBuilder::SetDiffScan docs
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13837 )
Change subject: Fix KuduScanTokenBuilder::SetDiffScan docs
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I448c00b78f9d14685e87d154e1bbee0eaa8e8e24
Gerrit-Change-Number: 13837
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 10 Jul 2019 21:29:40 +0000
Gerrit-HasComments: No