[GitHub] [incubator-datasketches-cpp] AlexanderSaydakov opened a new pull request #168: KLL merge blocks fix

[GitBox <gi...@apache.org>]

AlexanderSaydakov opened a new pull request #168:
URL: https://github.com/apache/incubator-datasketches-cpp/pull/168


   The Quantile Calculator makes a temporary copy of all retained items in the sketch, merges sorted levels and assigns cumulative weight to retained items. The current implementation was designed (in Java) to copy items, and was incorrectly modified to do moves. The problem did not affect integral types, but might lead to incorrect behavior or crash for some other types depending on the types internal implementation. The proposed change should mitigate the problem.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org

[GitHub] [incubator-datasketches-cpp] AlexanderSaydakov merged pull request #168: KLL merge blocks fix

[GitBox <gi...@apache.org>]

AlexanderSaydakov merged pull request #168:
URL: https://github.com/apache/incubator-datasketches-cpp/pull/168


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org