You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mrunit.apache.org by "Brock Noland (Created) (JIRA)" <ji...@apache.org> on 2011/11/29 13:41:44 UTC
[jira] [Created] (MRUNIT-48) Test and Deprecate
Driver.{*OutputFromString,*InputFromString} Methods
Test and Deprecate Driver.{*OutputFromString,*InputFromString} Methods
----------------------------------------------------------------------
Key: MRUNIT-48
URL: https://issues.apache.org/jira/browse/MRUNIT-48
Project: MRUnit
Issue Type: Improvement
Reporter: Brock Noland
Priority: Minor
We should test a driver that only deals with, say LongWritable, to ensure the runTest() method fails when we use the Driver.{*OutputFromString,*InputFromString} Methods.
Additionally, I think we should deprecate these methods since they don't play well with our generic interfaces.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MRUNIT-48) Test and Deprecate
Driver.{*OutputFromString,*InputFromString} Methods
Posted by "Jim Donofrio (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Donofrio updated MRUNIT-48:
-------------------------------
Attachment: MRUNIT-48-1.patch
deprecated all add/with Output/Input FromString methods
added test to confirm that using InputFromString with a mapper or reducer that doesnt take a Text will throw a ClassCastException which is probably good enough
However, OutputFromString is confusing because the log output will print the exact same output which isnt equal because the classes dont match. Added to additional else if statements in TestDriver to throw/log a more meaningful error such as "Missing expected output (a, 1): Mismatch in value class: expected: class org.apache.hadoop.io.Text actual: class org.apache.hadoop.io.LongWritable" instead of seeing:
Received unexpected output (a, 1)
MIssing expected output (a, 1)
Only test these cases in mrunit.TestMapDriver because all validation is done through the common TestDriver class
After a release are we going to delete these methods, they seem to add more confusion than they are worth?
> Test and Deprecate Driver.{*OutputFromString,*InputFromString} Methods
> ----------------------------------------------------------------------
>
> Key: MRUNIT-48
> URL: https://issues.apache.org/jira/browse/MRUNIT-48
> Project: MRUnit
> Issue Type: Improvement
> Reporter: Brock Noland
> Priority: Minor
> Fix For: 1.0.0
>
> Attachments: MRUNIT-48-1.patch
>
>
> We should test a driver that only deals with, say LongWritable, to ensure the runTest() method fails when we use the Driver.{*OutputFromString,*InputFromString} Methods.
> Additionally, I think we should deprecate these methods since they don't play well with our generic interfaces.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MRUNIT-48) Test and Deprecate
Driver.{*OutputFromString,*InputFromString} Methods
Posted by "Jim Donofrio (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Donofrio resolved MRUNIT-48.
--------------------------------
Resolution: Fixed
Assignee: Jim Donofrio
Committed in 1297378
> Test and Deprecate Driver.{*OutputFromString,*InputFromString} Methods
> ----------------------------------------------------------------------
>
> Key: MRUNIT-48
> URL: https://issues.apache.org/jira/browse/MRUNIT-48
> Project: MRUnit
> Issue Type: Improvement
> Reporter: Brock Noland
> Assignee: Jim Donofrio
> Priority: Minor
> Fix For: 1.0.0
>
> Attachments: MRUNIT-48-1.patch
>
>
> We should test a driver that only deals with, say LongWritable, to ensure the runTest() method fails when we use the Driver.{*OutputFromString,*InputFromString} Methods.
> Additionally, I think we should deprecate these methods since they don't play well with our generic interfaces.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MRUNIT-48) Test and Deprecate
Driver.{*OutputFromString,*InputFromString} Methods
Posted by "Jim Donofrio (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216622#comment-13216622 ]
Jim Donofrio commented on MRUNIT-48:
------------------------------------
I am not sure what you mean by this, do you mean only pass in a key with no tab delimited value so that the input or output method doesnt add a input or output?
> Test and Deprecate Driver.{*OutputFromString,*InputFromString} Methods
> ----------------------------------------------------------------------
>
> Key: MRUNIT-48
> URL: https://issues.apache.org/jira/browse/MRUNIT-48
> Project: MRUnit
> Issue Type: Improvement
> Reporter: Brock Noland
> Priority: Minor
> Fix For: 1.0.0
>
>
> We should test a driver that only deals with, say LongWritable, to ensure the runTest() method fails when we use the Driver.{*OutputFromString,*InputFromString} Methods.
> Additionally, I think we should deprecate these methods since they don't play well with our generic interfaces.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MRUNIT-48) Test and Deprecate
Driver.{*OutputFromString,*InputFromString} Methods
Posted by "Brock Noland (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brock Noland updated MRUNIT-48:
-------------------------------
Fix Version/s: 0.8.0
> Test and Deprecate Driver.{*OutputFromString,*InputFromString} Methods
> ----------------------------------------------------------------------
>
> Key: MRUNIT-48
> URL: https://issues.apache.org/jira/browse/MRUNIT-48
> Project: MRUnit
> Issue Type: Improvement
> Reporter: Brock Noland
> Priority: Minor
> Fix For: 0.8.0
>
>
> We should test a driver that only deals with, say LongWritable, to ensure the runTest() method fails when we use the Driver.{*OutputFromString,*InputFromString} Methods.
> Additionally, I think we should deprecate these methods since they don't play well with our generic interfaces.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MRUNIT-48) Test and Deprecate
Driver.{*OutputFromString,*InputFromString} Methods
Posted by "Brock Noland (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224507#comment-13224507 ]
Brock Noland commented on MRUNIT-48:
------------------------------------
Cool! Yes, I think we should remove then in the next major release after 1.0.
> Test and Deprecate Driver.{*OutputFromString,*InputFromString} Methods
> ----------------------------------------------------------------------
>
> Key: MRUNIT-48
> URL: https://issues.apache.org/jira/browse/MRUNIT-48
> Project: MRUnit
> Issue Type: Improvement
> Reporter: Brock Noland
> Assignee: Jim Donofrio
> Priority: Minor
> Fix For: 1.0.0
>
> Attachments: MRUNIT-48-1.patch
>
>
> We should test a driver that only deals with, say LongWritable, to ensure the runTest() method fails when we use the Driver.{*OutputFromString,*InputFromString} Methods.
> Additionally, I think we should deprecate these methods since they don't play well with our generic interfaces.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MRUNIT-48) Test and Deprecate
Driver.{*OutputFromString,*InputFromString} Methods
Posted by "Brock Noland (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216631#comment-13216631 ]
Brock Noland commented on MRUNIT-48:
------------------------------------
If a MRUnit test is using say LongWritable as the key, it's still possible to use the setOutputFromString methods. The setOutputFromString methods have no way of knowing the key should be a LongWritable. As such, I think we should 1) deprecate these methods 2) write a unit test to confirm that if the key is a non-Text type, MRUnit actually fails somewhere with a good error message.
> Test and Deprecate Driver.{*OutputFromString,*InputFromString} Methods
> ----------------------------------------------------------------------
>
> Key: MRUNIT-48
> URL: https://issues.apache.org/jira/browse/MRUNIT-48
> Project: MRUnit
> Issue Type: Improvement
> Reporter: Brock Noland
> Priority: Minor
> Fix For: 1.0.0
>
>
> We should test a driver that only deals with, say LongWritable, to ensure the runTest() method fails when we use the Driver.{*OutputFromString,*InputFromString} Methods.
> Additionally, I think we should deprecate these methods since they don't play well with our generic interfaces.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MRUNIT-48) Test and Deprecate
Driver.{*OutputFromString,*InputFromString} Methods
Posted by "Brock Noland (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brock Noland updated MRUNIT-48:
-------------------------------
Fix Version/s: (was: 0.8.0)
1.0.0
> Test and Deprecate Driver.{*OutputFromString,*InputFromString} Methods
> ----------------------------------------------------------------------
>
> Key: MRUNIT-48
> URL: https://issues.apache.org/jira/browse/MRUNIT-48
> Project: MRUnit
> Issue Type: Improvement
> Reporter: Brock Noland
> Priority: Minor
> Fix For: 1.0.0
>
>
> We should test a driver that only deals with, say LongWritable, to ensure the runTest() method fails when we use the Driver.{*OutputFromString,*InputFromString} Methods.
> Additionally, I think we should deprecate these methods since they don't play well with our generic interfaces.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira