[GitHub] [incubator-kyuubi] hddong commented on a change in pull request #1598: [KYUUBI #1582] Use ClientTypeSignature to further analysis of trino column type

[GitBox <gi...@apache.org>]

hddong commented on a change in pull request #1598:
URL: https://github.com/apache/incubator-kyuubi/pull/1598#discussion_r773574820



##########
File path: externals/kyuubi-trino-engine/src/main/scala/org/apache/kyuubi/engine/trino/schema/RowSet.scala
##########
@@ -237,46 +238,32 @@ object RowSet {
         // Only match string in nested type values
         "\"" + s + "\""
 
-      // for Array Map and Row, temporarily convert to string
-      // TODO further analysis of type
-      case (list: java.util.List[_], _) =>
-        formatValue(list)
+      case (list: java.util.List[_], ARRAY) if typ.getArgumentsAsTypeSignatures.size() > 0 =>

Review comment:
       > why the guard is needed here?
   
   Have call `getArgumentsAsTypeSignatures .get(0)` below, used to avoid out of index. However, it may not be necessary, because `getArgumentsAsTypeSignatures.get(0)` always has a value.
   Have removed it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org