[jira] [Commented] (FLUME-2243) AvroSource to use TransceiverThreadFactory for Thread naming while initializing NioServerSocketChannelFactory

["Gopinathan A (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLUME-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843237#comment-13843237 ] 

Gopinathan A commented on FLUME-2243:
-------------------------------------

+1 for patch

> AvroSource to use TransceiverThreadFactory for Thread naming while initializing NioServerSocketChannelFactory
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: FLUME-2243
>                 URL: https://issues.apache.org/jira/browse/FLUME-2243
>             Project: Flume
>          Issue Type: Improvement
>          Components: Sinks+Sources
>    Affects Versions: v1.4.0
>            Reporter: Ashish Paliwal
>            Assignee: Ashish Paliwal
>            Priority: Minor
>         Attachments: FLUME-2243-0.patch
>
>
> Currently in Avro source, we use 
> socketChannelFactory = new NioServerSocketChannelFactory
>           (Executors .newCachedThreadPool(), Executors.newCachedThreadPool());
> This would create generic Thread names like pool-1-thread-1. It would be good to use a ThreadFactory, like we use in NettyAvroRpcClient for better identification of Threads in log file
> ExecutorService bossExecutor = Executors.newCachedThreadPool(new TransceiverThreadFactory(
>           "Avro " + NettyTransceiver.class.getSimpleName() + " Boss"));
>       ExecutorService workerExecutor = Executors.newCachedThreadPool(new TransceiverThreadFactory(
>           "Avro " + NettyTransceiver.class.getSimpleName() + " I/O Worker"));



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)