[GitHub] [phoenix-connectors] stoty commented on a change in pull request #20: PHOENIX-5965 Remove Guava from Phoenix-Connectors

[GitBox <gi...@apache.org>]

stoty commented on a change in pull request #20:
URL: https://github.com/apache/phoenix-connectors/pull/20#discussion_r441417002



##########
File path: phoenix-hive/src/main/java/org/apache/phoenix/hive/PhoenixMetaHook.java
##########
@@ -94,8 +89,12 @@ private String createTableStatement(Table table) throws MetaException {
         String phoenixRowKeys = tableParameterMap.get(PhoenixStorageHandlerConstants
                 .PHOENIX_ROWKEYS);
         StringBuilder realRowKeys = new StringBuilder();
-        List<String> phoenixRowKeyList = Lists.newArrayList(Splitter.on
-                (PhoenixStorageHandlerConstants.COMMA).trimResults().split(phoenixRowKeys));
+        List<String> phoenixRowKeyList = new ArrayList<>(

Review comment:
       You must not use Java 8 features. Phoenix 4.x targets Java 7, and the connectors repo has to work with it.

##########
File path: phoenix-flume/src/main/java/org/apache/phoenix/flume/serializer/BaseEventSerializer.java
##########
@@ -27,7 +27,9 @@
 import java.sql.DriverManager;

Review comment:
       You have reformatted this, which makes reviewing hard.

##########
File path: phoenix-hive/src/it/java/org/apache/phoenix/hive/HiveTestUtil.java
##########
@@ -1160,7 +1160,7 @@ public static String ensurePathEndsInSlash(String path) {
     }
 
     private static String[] cachedQvFileList = null;
-    private static ImmutableList<String> cachedDefaultQvFileList = null;
+    private static List<String> cachedDefaultQvFileList = List.of();

Review comment:
       While this won't cause an error, this is not equivalent to the previous.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org