You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/07/15 14:48:38 UTC
[GitHub] [servicecomb-java-chassis] codecov-commenter edited a comment on pull request #2468: SCB-2295 Governance supports time periods of string type
codecov-commenter edited a comment on pull request #2468:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2468#issuecomment-880378990
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2468?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2468](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2468?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6a3e17c) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/6be3c5ef2afc1798c70baf82f6bde8eca2419614?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6be3c5e) will **decrease** coverage by `0.09%`.
> The diff coverage is `34.56%`.
[](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2468 +/- ##
============================================
- Coverage 79.93% 79.84% -0.10%
Complexity 1415 1415
============================================
Files 1549 1552 +3
Lines 41400 41495 +95
Branches 3453 3460 +7
============================================
+ Hits 33095 33130 +35
- Misses 6823 6876 +53
- Partials 1482 1489 +7
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ervicecomb/governance/handler/BulkheadHandler.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2468/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z292ZXJuYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZ292ZXJuYW5jZS9oYW5kbGVyL0J1bGtoZWFkSGFuZGxlci5qYXZh) | `16.66% <0.00%> (ø)` | |
| [...comb/governance/handler/CircuitBreakerHandler.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2468/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z292ZXJuYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZ292ZXJuYW5jZS9oYW5kbGVyL0NpcmN1aXRCcmVha2VySGFuZGxlci5qYXZh) | `11.11% <0.00%> (ø)` | |
| [...e/servicecomb/governance/handler/RetryHandler.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2468/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z292ZXJuYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZ292ZXJuYW5jZS9oYW5kbGVyL1JldHJ5SGFuZGxlci5qYXZh) | `10.52% <0.00%> (-1.24%)` | :arrow_down: |
| [...governance/handler/ext/AbstractRetryExtension.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2468/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z292ZXJuYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZ292ZXJuYW5jZS9oYW5kbGVyL2V4dC9BYnN0cmFjdFJldHJ5RXh0ZW5zaW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...mb/governance/properties/GovernanceProperties.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2468/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z292ZXJuYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZ292ZXJuYW5jZS9wcm9wZXJ0aWVzL0dvdmVybmFuY2VQcm9wZXJ0aWVzLmphdmE=) | `80.00% <ø> (ø)` | |
| [.../servicecomb/governance/utils/GovernanceUtils.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2468/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z292ZXJuYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZ292ZXJuYW5jZS91dGlscy9Hb3Zlcm5hbmNlVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...che/servicecomb/governance/policy/RetryPolicy.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2468/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z292ZXJuYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZ292ZXJuYW5jZS9wb2xpY3kvUmV0cnlQb2xpY3kuamF2YQ==) | `37.20% <28.57%> (-7.80%)` | :arrow_down: |
| [...cecomb/governance/policy/CircuitBreakerPolicy.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2468/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z292ZXJuYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZ292ZXJuYW5jZS9wb2xpY3kvQ2lyY3VpdEJyZWFrZXJQb2xpY3kuamF2YQ==) | `40.74% <50.00%> (+2.27%)` | :arrow_up: |
| [...vicecomb/governance/policy/RateLimitingPolicy.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2468/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z292ZXJuYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZ292ZXJuYW5jZS9wb2xpY3kvUmF0ZUxpbWl0aW5nUG9saWN5LmphdmE=) | `66.66% <50.00%> (+3.03%)` | :arrow_up: |
| [.../servicecomb/governance/policy/AbstractPolicy.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2468/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z292ZXJuYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZ292ZXJuYW5jZS9wb2xpY3kvQWJzdHJhY3RQb2xpY3kuamF2YQ==) | `53.33% <54.54%> (+3.33%)` | :arrow_up: |
| ... and [18 more](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2468/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2468?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2468?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6be3c5e...6a3e17c](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2468?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org