You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joshua Cohen <jc...@apache.org> on 2016/02/11 17:54:08 UTC
Review Request 43486: Fix the executor to fail tasks quickly in the
event of unknown exceptions when creating sandboxes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43486/
-----------------------------------------------------------
Review request for Aurora, John Sirois and Zameer Manji.
Repository: aurora
Description
-------
Fix the executor to fail tasks quickly in the event of unknown exceptions when creating sandboxes.
Diffs
-----
src/main/python/apache/aurora/executor/aurora_executor.py 96d7a336deebc4c95405d237df0ee11e7e055aa2
src/main/python/apache/aurora/executor/common/sandbox.py d4c366e5deba1b03d1727dcc06e41661fff6c2ee
src/test/python/apache/aurora/executor/common/test_directory_sandbox.py a80c6ef8efad6e2f1696c2555f3d5527a8a7f77a
src/test/python/apache/aurora/executor/test_thermos_executor.py 32e8b9bad4803b2196716cbc6710366a8a8c01a3
Diff: https://reviews.apache.org/r/43486/diff/
Testing
-------
./build-support/python/jenkins.sh
Thanks,
Joshua Cohen
Re: Review Request 43486: Fix the executor to fail tasks quickly in
the event of unknown exceptions when creating sandboxes.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43486/#review118886
-----------------------------------------------------------
Ship it!
Master (e7862e0) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 11, 2016, 4:54 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43486/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2016, 4:54 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Bugs: AURORA-1614
> https://issues.apache.org/jira/browse/AURORA-1614
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix the executor to fail tasks quickly in the event of unknown exceptions when creating sandboxes.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/aurora_executor.py 96d7a336deebc4c95405d237df0ee11e7e055aa2
> src/main/python/apache/aurora/executor/common/sandbox.py d4c366e5deba1b03d1727dcc06e41661fff6c2ee
> src/test/python/apache/aurora/executor/common/test_directory_sandbox.py a80c6ef8efad6e2f1696c2555f3d5527a8a7f77a
> src/test/python/apache/aurora/executor/test_thermos_executor.py 32e8b9bad4803b2196716cbc6710366a8a8c01a3
>
> Diff: https://reviews.apache.org/r/43486/diff/
>
>
> Testing
> -------
>
> ./build-support/python/jenkins.sh
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 43486: Fix the executor to fail tasks quickly in
the event of unknown exceptions when creating sandboxes.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43486/#review118903
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Feb. 11, 2016, 8:54 a.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43486/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2016, 8:54 a.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Bugs: AURORA-1614
> https://issues.apache.org/jira/browse/AURORA-1614
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix the executor to fail tasks quickly in the event of unknown exceptions when creating sandboxes.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/aurora_executor.py 96d7a336deebc4c95405d237df0ee11e7e055aa2
> src/main/python/apache/aurora/executor/common/sandbox.py d4c366e5deba1b03d1727dcc06e41661fff6c2ee
> src/test/python/apache/aurora/executor/common/test_directory_sandbox.py a80c6ef8efad6e2f1696c2555f3d5527a8a7f77a
> src/test/python/apache/aurora/executor/test_thermos_executor.py 32e8b9bad4803b2196716cbc6710366a8a8c01a3
>
> Diff: https://reviews.apache.org/r/43486/diff/
>
>
> Testing
> -------
>
> ./build-support/python/jenkins.sh
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 43486: Fix the executor to fail tasks quickly in
the event of unknown exceptions when creating sandboxes.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43486/#review118883
-----------------------------------------------------------
Ship it!
Ship It!
- John Sirois
On Feb. 11, 2016, 9:54 a.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43486/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2016, 9:54 a.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Bugs: AURORA-1614
> https://issues.apache.org/jira/browse/AURORA-1614
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix the executor to fail tasks quickly in the event of unknown exceptions when creating sandboxes.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/aurora_executor.py 96d7a336deebc4c95405d237df0ee11e7e055aa2
> src/main/python/apache/aurora/executor/common/sandbox.py d4c366e5deba1b03d1727dcc06e41661fff6c2ee
> src/test/python/apache/aurora/executor/common/test_directory_sandbox.py a80c6ef8efad6e2f1696c2555f3d5527a8a7f77a
> src/test/python/apache/aurora/executor/test_thermos_executor.py 32e8b9bad4803b2196716cbc6710366a8a8c01a3
>
> Diff: https://reviews.apache.org/r/43486/diff/
>
>
> Testing
> -------
>
> ./build-support/python/jenkins.sh
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 43486: Fix the executor to fail tasks quickly in
the event of unknown exceptions when creating sandboxes.
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43486/
-----------------------------------------------------------
(Updated Feb. 11, 2016, 4:54 p.m.)
Review request for Aurora, John Sirois and Zameer Manji.
Changes
-------
+ticket
Bugs: AURORA-1614
https://issues.apache.org/jira/browse/AURORA-1614
Repository: aurora
Description
-------
Fix the executor to fail tasks quickly in the event of unknown exceptions when creating sandboxes.
Diffs
-----
src/main/python/apache/aurora/executor/aurora_executor.py 96d7a336deebc4c95405d237df0ee11e7e055aa2
src/main/python/apache/aurora/executor/common/sandbox.py d4c366e5deba1b03d1727dcc06e41661fff6c2ee
src/test/python/apache/aurora/executor/common/test_directory_sandbox.py a80c6ef8efad6e2f1696c2555f3d5527a8a7f77a
src/test/python/apache/aurora/executor/test_thermos_executor.py 32e8b9bad4803b2196716cbc6710366a8a8c01a3
Diff: https://reviews.apache.org/r/43486/diff/
Testing
-------
./build-support/python/jenkins.sh
Thanks,
Joshua Cohen