[GitHub] [incubator-sedona] krishnarb3 commented on a diff in pull request #624: [SEDONA-120] Add ST_BuildArea function and tests

[GitBox <gi...@apache.org>]

krishnarb3 commented on code in PR #624:
URL: https://github.com/apache/incubator-sedona/pull/624#discussion_r857575820


##########
sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/Functions.scala:
##########
@@ -1782,3 +1782,26 @@ case class ST_XMin(inputExpressions: Seq[Expression])
     copy(inputExpressions = newChildren)
   }
 }
+
+
+/**
+ * Returns the areal geometry formed by the constituent linework of the input geometry assuming assumes all inner geometries represent holes
+ *
+ * @param inputExpressions
+ */
+case class ST_BuildArea(inputExpressions: Seq[Expression])
+  extends UnaryGeometryExpression with CodegenFallback {
+  assert(inputExpressions.length == 1)
+
+  override protected def nullSafeEval(geometry: Geometry): Any = {

Review Comment:
   Should this be a nullable function?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org