You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/07/31 22:16:41 UTC
[GitHub] codecov-io edited a comment on issue #4725: Add "Published" feature
to dashboards
codecov-io edited a comment on issue #4725: Add "Published" feature to dashboards
URL: https://github.com/apache/incubator-superset/pull/4725#issuecomment-379818360
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4725?src=pr&el=h1) Report
> Merging [#4725](https://codecov.io/gh/apache/incubator-superset/pull/4725?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/918399d4e294e86e7b7efd85e8d7c1bcddcfe2eb?src=pr&el=desc) will **decrease** coverage by `13.73%`.
> The diff coverage is `73.31%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/4725/graphs/tree.svg?token=KsB0fHcx6l&src=pr&height=150&width=650)](https://codecov.io/gh/apache/incubator-superset/pull/4725?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4725 +/- ##
==========================================
- Coverage 77.03% 63.3% -13.74%
==========================================
Files 44 350 +306
Lines 8595 22246 +13651
Branches 0 2465 +2465
==========================================
+ Hits 6621 14082 +7461
- Misses 1974 8150 +6176
- Partials 0 14 +14
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4725?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset/assets/src/dashboard/reducers/datasources.js](https://codecov.io/gh/apache/incubator-superset/pull/4725/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGF0YXNvdXJjZXMuanM=) | `62.5% <ø> (ø)` | |
| [superset/assets/src/explore/components/Control.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4725/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvQ29udHJvbC5qc3g=) | `38.09% <ø> (ø)` | |
| [...ssets/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4725/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvRXhwbG9yZUNoYXJ0UGFuZWwuanN4) | `0% <ø> (ø)` | |
| [...et/assets/src/dashboard/util/headerStyleOptions.js](https://codecov.io/gh/apache/incubator-superset/pull/4725/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9oZWFkZXJTdHlsZU9wdGlvbnMuanM=) | `100% <ø> (ø)` | |
| [...ets/src/dashboard/util/findFirstParentContainer.js](https://codecov.io/gh/apache/incubator-superset/pull/4725/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9maW5kRmlyc3RQYXJlbnRDb250YWluZXIuanM=) | `100% <ø> (ø)` | |
| [.../src/explore/components/ControlPanelsContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4725/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvQ29udHJvbFBhbmVsc0NvbnRhaW5lci5qc3g=) | `88.15% <ø> (ø)` | |
| [...ssets/src/explore/components/AdhocMetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4725/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvQWRob2NNZXRyaWNPcHRpb24uanN4) | `87.09% <ø> (ø)` | |
| [superset/assets/src/dashboard/util/isValidChild.js](https://codecov.io/gh/apache/incubator-superset/pull/4725/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9pc1ZhbGlkQ2hpbGQuanM=) | `92.85% <ø> (ø)` | |
| [...ts/src/explore/components/ExploreActionButtons.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4725/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvRXhwbG9yZUFjdGlvbkJ1dHRvbnMuanN4) | `100% <ø> (ø)` | |
| [superset/assets/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/4725/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9kbmQtcmVvcmRlci5qcw==) | `100% <ø> (ø)` | |
| ... and [460 more](https://codecov.io/gh/apache/incubator-superset/pull/4725/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4725?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4725?src=pr&el=footer). Last update [918399d...3cd1ae3](https://codecov.io/gh/apache/incubator-superset/pull/4725?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org