You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Wes McKinney (Jira)" <ji...@apache.org> on 2020/06/18 23:02:00 UTC

[jira] [Resolved] (ARROW-9022) [C++] Add/Sub/Mul arithmetic kernels with overflow check

     [ https://issues.apache.org/jira/browse/ARROW-9022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wes McKinney resolved ARROW-9022.
---------------------------------
    Resolution: Fixed

Issue resolved by pull request 7420
[https://github.com/apache/arrow/pull/7420]

> [C++] Add/Sub/Mul arithmetic kernels with overflow check
> --------------------------------------------------------
>
>                 Key: ARROW-9022
>                 URL: https://issues.apache.org/jira/browse/ARROW-9022
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Krisztian Szucs
>            Assignee: Krisztian Szucs
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.0.0
>
>          Time Spent: 5h 20m
>  Remaining Estimate: 0h
>
> -Currently the output type of the Add function is identical with the argument types which makes it unsafe to add numeric limit values, so instead of using {{(int8, int8) -> int8}} signature we should use {{((int8, int8) -> int16}}.-
> The current kernels do wrap around for performance reasons, so implement different kernels with overflow checking and add arithmetics options to let the caller choose which variant to run



--
This message was sent by Atlassian Jira
(v8.3.4#803005)