You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/07/17 08:11:47 UTC
[GitHub] [hudi] liujinhui1994 opened a new pull request, #6122: [HUDI-4409]
liujinhui1994 opened a new pull request, #6122:
URL: https://github.com/apache/hudi/pull/6122
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
Add Thread.sleep to catch.
The previous logic will throw an exception directly when the lock cannot be obtained, and Thread.sleep cannot take effect
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6122: [HUDI-4409] LockManager improve wait time logic
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6122:
URL: https://github.com/apache/hudi/pull/6122#issuecomment-1186715598
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d3c896da8d2e2d50ca806a9ca630ac5b3d0ef6d5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10001",
"triggerID" : "d3c896da8d2e2d50ca806a9ca630ac5b3d0ef6d5",
"triggerType" : "PUSH"
}, {
"hash" : "cf4238bd32291c0003bf4157bfa84db90fb2f82d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10018",
"triggerID" : "cf4238bd32291c0003bf4157bfa84db90fb2f82d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d3c896da8d2e2d50ca806a9ca630ac5b3d0ef6d5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10001)
* cf4238bd32291c0003bf4157bfa84db90fb2f82d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10018)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] fengjian428 commented on pull request #6122: [HUDI-4409] LockManager improve wait time logic
Posted by GitBox <gi...@apache.org>.
fengjian428 commented on PR #6122:
URL: https://github.com/apache/hudi/pull/6122#issuecomment-1186816730
> > I also found this, but there is a LOCK_ACQUIRE_WAIT_TIMEOUT_MS when using zk or hive lock provider, so I feel this may not be a big problem.
>
> The config items: LOCK_ACQUIRE_WAIT_TIMEOUT_MS and LOCK_ACQUIRE_CLIENT_RETRY_WAIT_TIME_IN_MILLIS are different. The front one is to define the timeout of acquisition and the second is for the retry interval. If we do not have an interval between retry, then the while loop will finish faster.
>
> > I have another idea, can we let every lock provider return false if it cannot acquire a lock? WDYT
>
> Why? what's the purpose?
What I mean is, For now, zk lock provider and hive lock provider never return false when tryLock, hence it will always return an Exception, Why can't it return false? is it make sense to always return Exception?
if want to return false or return HoodieLockException or return InterruptedException, you need some motivation, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] fengjian428 commented on pull request #6122: [HUDI-4409] LockManager improve wait time logic
Posted by GitBox <gi...@apache.org>.
fengjian428 commented on PR #6122:
URL: https://github.com/apache/hudi/pull/6122#issuecomment-1186730868
Cool~ I also found this, but there is a LOCK_ACQUIRE_WAIT_TIMEOUT_MS when using zk or hive lock provider, so I feel this may not be a big problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua commented on pull request #6122: [HUDI-4409] LockManager improve wait time logic
Posted by GitBox <gi...@apache.org>.
yanghua commented on PR #6122:
URL: https://github.com/apache/hudi/pull/6122#issuecomment-1186797199
> I also found this, but there is a LOCK_ACQUIRE_WAIT_TIMEOUT_MS when using zk or hive lock provider, so I feel this may not be a big problem.
The config items: LOCK_ACQUIRE_WAIT_TIMEOUT_MS and LOCK_ACQUIRE_CLIENT_RETRY_WAIT_TIME_IN_MILLIS are different.
The front one is to define the timeout of acquisition and the second is for the retry interval. If we do not have an interval between retry, then the while loop will finish faster.
> I have another idea, can we let every lock provider return false if it cannot acquire a lock? WDYT
Why? what's the purpose?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] liujinhui1994 commented on pull request #6122: [HUDI-4409] LockManager improve wait time logic
Posted by GitBox <gi...@apache.org>.
liujinhui1994 commented on PR #6122:
URL: https://github.com/apache/hudi/pull/6122#issuecomment-1186807647
> Cool~ I also found this, but there is a LOCK_ACQUIRE_WAIT_TIMEOUT_MS when using zk or hive lock provider, so I feel this may not be a big problem. I have another idea, can we let every lock provider return false if it cannot acquire a lock? WDYT
There are two different ways to solve this problem. @leesf @xiarixiaoyao what do you think？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua commented on pull request #6122: [HUDI-4409] LockManager improve wait time logic
Posted by GitBox <gi...@apache.org>.
yanghua commented on PR #6122:
URL: https://github.com/apache/hudi/pull/6122#issuecomment-1186848754
oops... I misunderstood your thought. I thought you want only return bool values for method `tryLock`.
> What I mean is, For now, zk lock provider and hive lock provider never return false when tryLock, hence it will always return an Exception, Why can't it return false? is it make sense to always return Exception? I feel maybe we need to make sure the behavior is properly first
if want to return false or return HoodieLockException or return InterruptedException, should mean something
eg: if lockprovider returns a IllegalArgumentException we don't need to retry since it will always illegal
reasonable.
IMHO, we can start a new thread to discuss this topic and if we need to refactor. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] fengjian428 commented on pull request #6122: [HUDI-4409] LockManager improve wait time logic
Posted by GitBox <gi...@apache.org>.
fengjian428 commented on PR #6122:
URL: https://github.com/apache/hudi/pull/6122#issuecomment-1186875902
> oops... I misunderstood your thought. I thought you want only return bool values for method `tryLock`.
>
> > What I mean is, For now, zk lock provider and hive lock provider never return false when tryLock, hence it will always return an Exception, Why can't it return false? is it make sense to always return Exception? I feel maybe we need to make sure the behavior is properly first
> > if want to return false or return HoodieLockException or return InterruptedException, should mean something
> > eg: if lockprovider returns a IllegalArgumentException we don't need to retry since it will always illegal
>
> reasonable.
>
> IMHO, we can start a new thread to discuss this topic and if we need to refactor. WDYT?
sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6122: [HUDI-4409] LockManager improve wait time logic
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6122:
URL: https://github.com/apache/hudi/pull/6122#issuecomment-1186713392
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d3c896da8d2e2d50ca806a9ca630ac5b3d0ef6d5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10001",
"triggerID" : "d3c896da8d2e2d50ca806a9ca630ac5b3d0ef6d5",
"triggerType" : "PUSH"
}, {
"hash" : "cf4238bd32291c0003bf4157bfa84db90fb2f82d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cf4238bd32291c0003bf4157bfa84db90fb2f82d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d3c896da8d2e2d50ca806a9ca630ac5b3d0ef6d5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10001)
* cf4238bd32291c0003bf4157bfa84db90fb2f82d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6122: [HUDI-4409] LockManager improve wait time logic
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6122:
URL: https://github.com/apache/hudi/pull/6122#issuecomment-1186443029
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d3c896da8d2e2d50ca806a9ca630ac5b3d0ef6d5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10001",
"triggerID" : "d3c896da8d2e2d50ca806a9ca630ac5b3d0ef6d5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d3c896da8d2e2d50ca806a9ca630ac5b3d0ef6d5 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10001)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6122: [HUDI-4409] LockManager improve wait time logic
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6122:
URL: https://github.com/apache/hudi/pull/6122#issuecomment-1187510930
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d3c896da8d2e2d50ca806a9ca630ac5b3d0ef6d5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10001",
"triggerID" : "d3c896da8d2e2d50ca806a9ca630ac5b3d0ef6d5",
"triggerType" : "PUSH"
}, {
"hash" : "cf4238bd32291c0003bf4157bfa84db90fb2f82d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10018",
"triggerID" : "cf4238bd32291c0003bf4157bfa84db90fb2f82d",
"triggerType" : "PUSH"
}, {
"hash" : "9328f441fef57f5a82785803255c021836a15842",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10028",
"triggerID" : "9328f441fef57f5a82785803255c021836a15842",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9328f441fef57f5a82785803255c021836a15842 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10028)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6122: [HUDI-4409] LockManager improve wait time logic
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6122:
URL: https://github.com/apache/hudi/pull/6122#issuecomment-1186470098
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d3c896da8d2e2d50ca806a9ca630ac5b3d0ef6d5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10001",
"triggerID" : "d3c896da8d2e2d50ca806a9ca630ac5b3d0ef6d5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d3c896da8d2e2d50ca806a9ca630ac5b3d0ef6d5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10001)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua commented on a diff in pull request #6122: [HUDI-4409] LockManager improve wait time logic
Posted by GitBox <gi...@apache.org>.
yanghua commented on code in PR #6122:
URL: https://github.com/apache/hudi/pull/6122#discussion_r922945243
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/LockManager.java:
##########
@@ -74,6 +74,11 @@ public void lock() {
if (retryCount >= maxRetries) {
throw new HoodieLockException("Unable to acquire lock, lock object ", e);
}
+ try {
Review Comment:
here (before `try`) add a blank line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua merged pull request #6122: [HUDI-4409] Improve LockManager wait logic when catch exception
Posted by GitBox <gi...@apache.org>.
yanghua merged PR #6122:
URL: https://github.com/apache/hudi/pull/6122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6122: [HUDI-4409] LockManager improve wait time logic
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6122:
URL: https://github.com/apache/hudi/pull/6122#issuecomment-1186442083
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d3c896da8d2e2d50ca806a9ca630ac5b3d0ef6d5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d3c896da8d2e2d50ca806a9ca630ac5b3d0ef6d5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d3c896da8d2e2d50ca806a9ca630ac5b3d0ef6d5 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua commented on pull request #6122: [HUDI-4409] LockManager improve wait time logic
Posted by GitBox <gi...@apache.org>.
yanghua commented on PR #6122:
URL: https://github.com/apache/hudi/pull/6122#issuecomment-1186716687
cc @fengjian428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6122: [HUDI-4409] LockManager improve wait time logic
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6122:
URL: https://github.com/apache/hudi/pull/6122#issuecomment-1186919523
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d3c896da8d2e2d50ca806a9ca630ac5b3d0ef6d5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10001",
"triggerID" : "d3c896da8d2e2d50ca806a9ca630ac5b3d0ef6d5",
"triggerType" : "PUSH"
}, {
"hash" : "cf4238bd32291c0003bf4157bfa84db90fb2f82d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10018",
"triggerID" : "cf4238bd32291c0003bf4157bfa84db90fb2f82d",
"triggerType" : "PUSH"
}, {
"hash" : "9328f441fef57f5a82785803255c021836a15842",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9328f441fef57f5a82785803255c021836a15842",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cf4238bd32291c0003bf4157bfa84db90fb2f82d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10018)
* 9328f441fef57f5a82785803255c021836a15842 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6122: [HUDI-4409] LockManager improve wait time logic
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6122:
URL: https://github.com/apache/hudi/pull/6122#issuecomment-1186924160
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d3c896da8d2e2d50ca806a9ca630ac5b3d0ef6d5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10001",
"triggerID" : "d3c896da8d2e2d50ca806a9ca630ac5b3d0ef6d5",
"triggerType" : "PUSH"
}, {
"hash" : "cf4238bd32291c0003bf4157bfa84db90fb2f82d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10018",
"triggerID" : "cf4238bd32291c0003bf4157bfa84db90fb2f82d",
"triggerType" : "PUSH"
}, {
"hash" : "9328f441fef57f5a82785803255c021836a15842",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10028",
"triggerID" : "9328f441fef57f5a82785803255c021836a15842",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cf4238bd32291c0003bf4157bfa84db90fb2f82d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10018)
* 9328f441fef57f5a82785803255c021836a15842 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10028)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] liujinhui1994 commented on pull request #6122: [HUDI-4409] LockManager improve wait time logic
Posted by GitBox <gi...@apache.org>.
liujinhui1994 commented on PR #6122:
URL: https://github.com/apache/hudi/pull/6122#issuecomment-1186803283
I have another idea, can we let every lock provider return false if it cannot acquire a lock? WDYT
@fengjian428 It's actually quite good to do so. In this way, the logic of the original waiting interval is maintained as much as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6122: [HUDI-4409] LockManager improve wait time logic
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6122:
URL: https://github.com/apache/hudi/pull/6122#issuecomment-1186773262
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d3c896da8d2e2d50ca806a9ca630ac5b3d0ef6d5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10001",
"triggerID" : "d3c896da8d2e2d50ca806a9ca630ac5b3d0ef6d5",
"triggerType" : "PUSH"
}, {
"hash" : "cf4238bd32291c0003bf4157bfa84db90fb2f82d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10018",
"triggerID" : "cf4238bd32291c0003bf4157bfa84db90fb2f82d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cf4238bd32291c0003bf4157bfa84db90fb2f82d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10018)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua commented on a diff in pull request #6122: [HUDI-4409] LockManager improve wait time logic
Posted by GitBox <gi...@apache.org>.
yanghua commented on code in PR #6122:
URL: https://github.com/apache/hudi/pull/6122#discussion_r922941155
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/LockManager.java:
##########
@@ -71,6 +71,12 @@ public void lock() {
LOG.info("Retrying to acquire lock...");
Thread.sleep(maxWaitTimeInMs);
} catch (HoodieLockException | InterruptedException e) {
+ try {
+ Thread.sleep(maxWaitTimeInMs);
+ } catch (InterruptedException ex) {
+ // ignore InterruptedException here
+ }
+
Review Comment:
Can we move this block behind the max-retry judgement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org