You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Ruchi Solani <ru...@freestoneinfotech.com> on 2017/12/04 11:10:34 UTC

Review Request 64296: Extra parameter "description" added when creating a type

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64296/
-----------------------------------------------------------

Review request for atlas and Madhan Neethiraj.


Bugs: ATLAS-2294
    https://issues.apache.org/jira/browse/ATLAS-2294


Repository: atlas


Description
-------

When creating a type , there is inconsistency with "description" parameter of the attributes in the type definition.
For example :
1.Adding no description parameter in the POST adds “description” :”” in the created type.
2.Adding “description” : “null" in the POST , no description parameter is found in the created type.


Diffs
-----

  intg/src/main/java/org/apache/atlas/model/typedef/AtlasRelationshipEndDef.java 5847eaf 
  intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 8f7f56f 


Diff: https://reviews.apache.org/r/64296/diff/1/


Testing
-------

Done basic developer testing.


Thanks,

Ruchi Solani


Re: Review Request 64296: Extra parameter "description" added when creating a type

Posted by David Radley <da...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64296/#review192757
-----------------------------------------------------------


Ship it!




Ship It!

- David Radley


On Dec. 4, 2017, 11:24 a.m., Ruchi Solani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64296/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2017, 11:24 a.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2294
>     https://issues.apache.org/jira/browse/ATLAS-2294
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> When creating a type , there is inconsistency with "description" parameter of the attributes in the type definition.
> For example :
> 1.Adding no description parameter in the POST adds “description” :”” in the created type.
> 2.Adding “description” : “null" in the POST , no description parameter is found in the created type.
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasRelationshipEndDef.java 5847eaf 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 8f7f56f 
> 
> 
> Diff: https://reviews.apache.org/r/64296/diff/1/
> 
> 
> Testing
> -------
> 
> Done sanity testing.
> 
> 
> Thanks,
> 
> Ruchi Solani
> 
>


Re: Review Request 64296: Extra parameter "description" added when creating a type

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64296/#review192694
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Dec. 4, 2017, 11:24 a.m., Ruchi Solani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64296/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2017, 11:24 a.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2294
>     https://issues.apache.org/jira/browse/ATLAS-2294
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> When creating a type , there is inconsistency with "description" parameter of the attributes in the type definition.
> For example :
> 1.Adding no description parameter in the POST adds “description” :”” in the created type.
> 2.Adding “description” : “null" in the POST , no description parameter is found in the created type.
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasRelationshipEndDef.java 5847eaf 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 8f7f56f 
> 
> 
> Diff: https://reviews.apache.org/r/64296/diff/1/
> 
> 
> Testing
> -------
> 
> Done sanity testing.
> 
> 
> Thanks,
> 
> Ruchi Solani
> 
>


Re: Review Request 64296: Extra parameter "description" added when creating a type

Posted by Ruchi Solani <ru...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64296/
-----------------------------------------------------------

(Updated Dec. 4, 2017, 11:24 a.m.)


Review request for atlas and Madhan Neethiraj.


Bugs: ATLAS-2294
    https://issues.apache.org/jira/browse/ATLAS-2294


Repository: atlas


Description
-------

When creating a type , there is inconsistency with "description" parameter of the attributes in the type definition.
For example :
1.Adding no description parameter in the POST adds “description” :”” in the created type.
2.Adding “description” : “null" in the POST , no description parameter is found in the created type.


Diffs
-----

  intg/src/main/java/org/apache/atlas/model/typedef/AtlasRelationshipEndDef.java 5847eaf 
  intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 8f7f56f 


Diff: https://reviews.apache.org/r/64296/diff/1/


Testing (updated)
-------

Done sanity testing.


Thanks,

Ruchi Solani