[jira] Commented: (HADOOP-1555) Fix a few more FindBugs issues

["Edward J. Yoon (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618970#action_12618970 ] 

Edward J. Yoon commented on HADOOP-1555:
----------------------------------------

Looks good for me.
Also, I didn't try, but you can fix 'BC_VACUOUS_INSTANCEOF' as below:

  if ((FileSystem) localFs instanceof ChecksumFileSystem) {
    ....


> Fix a few more FindBugs issues
> ------------------------------
>
>                 Key: HADOOP-1555
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1555
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.13.0
>            Reporter: Albert Strasheim
>         Attachments: findbugsv0.patch
>
>
> I'm attaching a patch to fix a few more FindBugs issues. Most of these fixes are relatively minor. I also went ahead and fixed some issues in the tests.
> This patch includes some fixes for "inconsistent synchronization" reported by FindBugs. However, FindBugs still reports some cases of inconsistent synchronization that I'm not quite sure how to fix.
> Also, in ChecksumFileSystem.copyToLocalFile, there is an instanceof ChecksumFileSystem check that FindBugs says will always return true. I'm not quite sure what was intended here.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.