You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2019/05/08 01:25:22 UTC

[GitHub] [incubator-hudi] pseudomuto opened a new pull request #670: SparkUtil#initLauncher shoudn't raise when spark-defaults.conf doesn't exist

pseudomuto opened a new pull request #670: SparkUtil#initLauncher shoudn't raise when spark-defaults.conf doesn't exist
URL: https://github.com/apache/incubator-hudi/pull/670
 
 
   @vinothchandar @n3nash 
   
   # The Problem
   
   When attempting to run the `hdfsparquetimport` command from the hoode-cli I ran into an issue where it raises when the file _spark-defaults.conf_ is not present.
   
   The `SparkLauncher` has a [check](https://github.com/apache/spark/blob/5e79ae3b40b76e3473288830ab958fc4834dcb33/launcher/src/main/java/org/apache/spark/launcher/AbstractLauncher.java#L45) that raises when this value is `null` which is the case when using a default spark download for example.
   
   # The Solution
   
   Since I couldn't find any reason to require this to be present, I simply added a `isEmpty` check to only set the properties file when the value isn't `null` or `""`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services