You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/01/22 14:05:26 UTC

Re: Review Request 28851: Query predicate .matches doesn't work for stacks endpoint with passed logical OR(Lexer Changes)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28851/
-----------------------------------------------------------

(Updated Янв. 22, 2015, 1:05 п.п.)


Review request for Ambari, John Speidel, Nate Cole, and Tom Beerbower.


Changes
-------

Uploading hare only lexer changes. For URL-encoding changes separated review board will be created.


Summary (updated)
-----------------

Query predicate .matches doesn't work for stacks endpoint with passed logical OR(Lexer Changes)


Bugs: AMBARI-8605
    https://issues.apache.org/jira/browse/AMBARI-8605


Repository: ambari


Description
-------

Stacks endpoint returns java exception for query predicate which use .matches and logical OR, for example:
/api/v1/stacks/HDP/versions/2.2/services/HIVE/configurations?fields=*&StackConfigurations/property_type.matches((.*USER.*)|(.*GROUP.*))

/api/v1/stacks/HDP/versions/2.2/services/HIVE/configurations?fields=*&(StackConfigurations/property_type.matches(.*USER.*)|StackConfigurations/property_type.matches(.*GROUP.*))

Regexp grouping with () doesn't work


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryLexer.java b645040 
  ambari-server/src/test/java/org/apache/ambari/server/api/predicate/QueryLexerTest.java 2c04d6c 

Diff: https://reviews.apache.org/r/28851/diff/


Testing
-------

[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main ....................................... SUCCESS [3.287s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.436s]
[INFO] Ambari Web ........................................ SUCCESS [42.942s]
[INFO] Ambari Views ...................................... SUCCESS [2.247s]
[INFO] Ambari Admin View ................................. SUCCESS [10.312s]
[INFO] Ambari Server ..................................... SUCCESS [31:07.912s]
[INFO] Ambari Agent ...................................... SUCCESS [6.565s]
[INFO] Ambari Client ..................................... SUCCESS [0.042s]
[INFO] Ambari Python Client .............................. SUCCESS [0.558s]
[INFO] Ambari Groovy Client .............................. SUCCESS [10.233s]
[INFO] Ambari Shell ...................................... SUCCESS [0.032s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.048s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [6.478s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS


Thanks,

Dmytro Sen

Re: Review Request 28851: Query predicate .matches doesn't work for stacks endpoint with passed logical OR(Lexer Changes)

Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28851/#review69193
-----------------------------------------------------------

Ship it!


Ship It!

- John Speidel


On Jan. 22, 2015, 1:05 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28851/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2015, 1:05 p.m.)
> 
> 
> Review request for Ambari, John Speidel, Nate Cole, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8605
>     https://issues.apache.org/jira/browse/AMBARI-8605
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Stacks endpoint returns java exception for query predicate which use .matches and logical OR, for example:
> /api/v1/stacks/HDP/versions/2.2/services/HIVE/configurations?fields=*&StackConfigurations/property_type.matches((.*USER.*)|(.*GROUP.*))
> 
> /api/v1/stacks/HDP/versions/2.2/services/HIVE/configurations?fields=*&(StackConfigurations/property_type.matches(.*USER.*)|StackConfigurations/property_type.matches(.*GROUP.*))
> 
> Regexp grouping with () doesn't work
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryLexer.java b645040 
>   ambari-server/src/test/java/org/apache/ambari/server/api/predicate/QueryLexerTest.java 2c04d6c 
> 
> Diff: https://reviews.apache.org/r/28851/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ....................................... SUCCESS [3.287s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.436s]
> [INFO] Ambari Web ........................................ SUCCESS [42.942s]
> [INFO] Ambari Views ...................................... SUCCESS [2.247s]
> [INFO] Ambari Admin View ................................. SUCCESS [10.312s]
> [INFO] Ambari Server ..................................... SUCCESS [31:07.912s]
> [INFO] Ambari Agent ...................................... SUCCESS [6.565s]
> [INFO] Ambari Client ..................................... SUCCESS [0.042s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.558s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [10.233s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.032s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.048s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [6.478s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 28851: Query predicate .matches doesn't work for stacks endpoint with passed logical OR(Lexer Changes)

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28851/#review69174
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Jan. 22, 2015, 8:05 a.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28851/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2015, 8:05 a.m.)
> 
> 
> Review request for Ambari, John Speidel, Nate Cole, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8605
>     https://issues.apache.org/jira/browse/AMBARI-8605
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Stacks endpoint returns java exception for query predicate which use .matches and logical OR, for example:
> /api/v1/stacks/HDP/versions/2.2/services/HIVE/configurations?fields=*&StackConfigurations/property_type.matches((.*USER.*)|(.*GROUP.*))
> 
> /api/v1/stacks/HDP/versions/2.2/services/HIVE/configurations?fields=*&(StackConfigurations/property_type.matches(.*USER.*)|StackConfigurations/property_type.matches(.*GROUP.*))
> 
> Regexp grouping with () doesn't work
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryLexer.java b645040 
>   ambari-server/src/test/java/org/apache/ambari/server/api/predicate/QueryLexerTest.java 2c04d6c 
> 
> Diff: https://reviews.apache.org/r/28851/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ....................................... SUCCESS [3.287s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.436s]
> [INFO] Ambari Web ........................................ SUCCESS [42.942s]
> [INFO] Ambari Views ...................................... SUCCESS [2.247s]
> [INFO] Ambari Admin View ................................. SUCCESS [10.312s]
> [INFO] Ambari Server ..................................... SUCCESS [31:07.912s]
> [INFO] Ambari Agent ...................................... SUCCESS [6.565s]
> [INFO] Ambari Client ..................................... SUCCESS [0.042s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.558s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [10.233s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.032s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.048s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [6.478s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 28851: Query predicate .matches doesn't work for stacks endpoint with passed logical OR(Lexer Changes)

Posted by Dmytro Sen <ds...@hortonworks.com>.

> On Янв. 22, 2015, 1:25 п.п., Tom Beerbower wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryLexer.java, line 640
> > <https://reviews.apache.org/r/28851/diff/2/?file=829785#file829785line640>
> >
> >     I wonder if this class and TokenHandler should be static.  They don't depend on an instance of QueryLexer, do they?
> 
> Nate Cole wrote:
>     +1

Left this class as is. Consider it as non-critical.


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28851/#review69171
-----------------------------------------------------------


On Янв. 22, 2015, 1:05 п.п., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28851/
> -----------------------------------------------------------
> 
> (Updated Янв. 22, 2015, 1:05 п.п.)
> 
> 
> Review request for Ambari, John Speidel, Nate Cole, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8605
>     https://issues.apache.org/jira/browse/AMBARI-8605
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Stacks endpoint returns java exception for query predicate which use .matches and logical OR, for example:
> /api/v1/stacks/HDP/versions/2.2/services/HIVE/configurations?fields=*&StackConfigurations/property_type.matches((.*USER.*)|(.*GROUP.*))
> 
> /api/v1/stacks/HDP/versions/2.2/services/HIVE/configurations?fields=*&(StackConfigurations/property_type.matches(.*USER.*)|StackConfigurations/property_type.matches(.*GROUP.*))
> 
> Regexp grouping with () doesn't work
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryLexer.java b645040 
>   ambari-server/src/test/java/org/apache/ambari/server/api/predicate/QueryLexerTest.java 2c04d6c 
> 
> Diff: https://reviews.apache.org/r/28851/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ....................................... SUCCESS [3.287s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.436s]
> [INFO] Ambari Web ........................................ SUCCESS [42.942s]
> [INFO] Ambari Views ...................................... SUCCESS [2.247s]
> [INFO] Ambari Admin View ................................. SUCCESS [10.312s]
> [INFO] Ambari Server ..................................... SUCCESS [31:07.912s]
> [INFO] Ambari Agent ...................................... SUCCESS [6.565s]
> [INFO] Ambari Client ..................................... SUCCESS [0.042s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.558s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [10.233s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.032s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.048s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [6.478s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 28851: Query predicate .matches doesn't work for stacks endpoint with passed logical OR(Lexer Changes)

Posted by Nate Cole <nc...@hortonworks.com>.

> On Jan. 22, 2015, 8:25 a.m., Tom Beerbower wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryLexer.java, line 640
> > <https://reviews.apache.org/r/28851/diff/2/?file=829785#file829785line640>
> >
> >     I wonder if this class and TokenHandler should be static.  They don't depend on an instance of QueryLexer, do they?

+1


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28851/#review69171
-----------------------------------------------------------


On Jan. 22, 2015, 8:05 a.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28851/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2015, 8:05 a.m.)
> 
> 
> Review request for Ambari, John Speidel, Nate Cole, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8605
>     https://issues.apache.org/jira/browse/AMBARI-8605
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Stacks endpoint returns java exception for query predicate which use .matches and logical OR, for example:
> /api/v1/stacks/HDP/versions/2.2/services/HIVE/configurations?fields=*&StackConfigurations/property_type.matches((.*USER.*)|(.*GROUP.*))
> 
> /api/v1/stacks/HDP/versions/2.2/services/HIVE/configurations?fields=*&(StackConfigurations/property_type.matches(.*USER.*)|StackConfigurations/property_type.matches(.*GROUP.*))
> 
> Regexp grouping with () doesn't work
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryLexer.java b645040 
>   ambari-server/src/test/java/org/apache/ambari/server/api/predicate/QueryLexerTest.java 2c04d6c 
> 
> Diff: https://reviews.apache.org/r/28851/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ....................................... SUCCESS [3.287s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.436s]
> [INFO] Ambari Web ........................................ SUCCESS [42.942s]
> [INFO] Ambari Views ...................................... SUCCESS [2.247s]
> [INFO] Ambari Admin View ................................. SUCCESS [10.312s]
> [INFO] Ambari Server ..................................... SUCCESS [31:07.912s]
> [INFO] Ambari Agent ...................................... SUCCESS [6.565s]
> [INFO] Ambari Client ..................................... SUCCESS [0.042s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.558s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [10.233s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.032s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.048s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [6.478s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 28851: Query predicate .matches doesn't work for stacks endpoint with passed logical OR(Lexer Changes)

Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28851/#review69171
-----------------------------------------------------------

Ship it!



ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryLexer.java
<https://reviews.apache.org/r/28851/#comment113782>

    I wonder if this class and TokenHandler should be static.  They don't depend on an instance of QueryLexer, do they?


- Tom Beerbower


On Jan. 22, 2015, 1:05 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28851/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2015, 1:05 p.m.)
> 
> 
> Review request for Ambari, John Speidel, Nate Cole, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-8605
>     https://issues.apache.org/jira/browse/AMBARI-8605
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Stacks endpoint returns java exception for query predicate which use .matches and logical OR, for example:
> /api/v1/stacks/HDP/versions/2.2/services/HIVE/configurations?fields=*&StackConfigurations/property_type.matches((.*USER.*)|(.*GROUP.*))
> 
> /api/v1/stacks/HDP/versions/2.2/services/HIVE/configurations?fields=*&(StackConfigurations/property_type.matches(.*USER.*)|StackConfigurations/property_type.matches(.*GROUP.*))
> 
> Regexp grouping with () doesn't work
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryLexer.java b645040 
>   ambari-server/src/test/java/org/apache/ambari/server/api/predicate/QueryLexerTest.java 2c04d6c 
> 
> Diff: https://reviews.apache.org/r/28851/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ....................................... SUCCESS [3.287s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.436s]
> [INFO] Ambari Web ........................................ SUCCESS [42.942s]
> [INFO] Ambari Views ...................................... SUCCESS [2.247s]
> [INFO] Ambari Admin View ................................. SUCCESS [10.312s]
> [INFO] Ambari Server ..................................... SUCCESS [31:07.912s]
> [INFO] Ambari Agent ...................................... SUCCESS [6.565s]
> [INFO] Ambari Client ..................................... SUCCESS [0.042s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.558s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [10.233s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.032s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.048s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [6.478s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>