You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:28:44 UTC

[GitHub] [incubator-mxnet] MoisesHer commented on pull request #18779: [WIP] Support extra inputs for subgraph ops

MoisesHer commented on pull request #18779:
URL: https://github.com/apache/incubator-mxnet/pull/18779#issuecomment-664816682


   > @eric-haibin-lin @MoisesHer what do you think about changing the graph pass API from taking a String (symbol JSON) to a Graph object like:
   From a user perspective (someone defining a pass) I think a graph is preferred. I guess the user will not have to re-implement class Graph  anymore, and will skip conversion from String <-> graph


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org