You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/16 12:54:08 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #2000: sched: Call up_[use|create]_stack after nxtask_setup_scheduler

xiaoxiang781216 opened a new pull request #2000:
URL: https://github.com/apache/incubator-nuttx/pull/2000


   ## Summary
   to ensure the basic info(e.g. pid) setup correctly before call arch API. and up_use_stack don't skip the colorize the stack:
   https://github.com/apache/incubator-nuttx/blob/master/arch/arm/src/common/arm_usestack.c#L159
   
   ## Impact
   pthread_create with caller provided stack get the color correctly.
   
   ## Testing
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 merged pull request #2000: sched: Call up_[use|create]_stack after nxtask_setup_scheduler

Posted by GitBox <gi...@apache.org>.
masayuki2009 merged pull request #2000:
URL: https://github.com/apache/incubator-nuttx/pull/2000


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #2000: sched: Call up_[use|create]_stack after nxtask_setup_scheduler

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #2000:
URL: https://github.com/apache/incubator-nuttx/pull/2000#issuecomment-713981065


   @xiaoxiang781216 
   May I merge this PR?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2000: sched: Call up_[use|create]_stack after nxtask_setup_scheduler

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2000:
URL: https://github.com/apache/incubator-nuttx/pull/2000#issuecomment-714262307


   Sure, please.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #2000: sched: Call up_[use|create]_stack after nxtask_setup_scheduler

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #2000:
URL: https://github.com/apache/incubator-nuttx/pull/2000#issuecomment-713245966


   LGTM
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #2000: sched: Call up_[use|create]_stack after nxtask_setup_scheduler

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #2000:
URL: https://github.com/apache/incubator-nuttx/pull/2000#issuecomment-714301028


   @xiaoxiang781216 
   Hmm, I found that spresense:elf failed
   
   ```
   CThingSayer::CThingSayer: I am!
   main: Created MyThingSayer=0x0d013e60
   main: Calling MyThingSayer->Initialize
   CThingSayer::Initialize: When told, I will say 'Hello, World!'
   main: Calling MyThingSayer->SayThing
   CThingSayer::SayThing: I am now saying 'Hello, World!'
   main: Destroying MyThingSayer
   CThingSayer::~CThingSayer: I cease to be
   CThingSayer::~CThingSayer: I will never say 'Hello, World!' again
   main: Returning
   
   Memory Usage after program execution:
     Before:     8960 After:     7696 Change:    -1264
   
   **********************************arm_hardfault: PANIC!!! Hard fault: 40000000
   up_assert: Assertion failed at file:armv7-m/arm_hardfault.c line: 134 task: <pthread>
   up_registerdump: R0: 0d014bf4 fffffff8 00000000 00000000 00000000 00000000 00000000 00000000
   up_registerdump: R8: 00000000 00000000 0d008360 01000000 0000000a 0d0138f0 0d004879 0d000324
   ```
   
   Sorry, let me revert.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org