You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org> on 2022/07/01 02:46:51 UTC

[kudu-CR] [java] KUDU-2671 support adding a range with custom hash schema

Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18589 )

Change subject: [java] KUDU-2671 support adding a range with custom hash schema
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18589/7/java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java:

PS7: 
Any specific reason we are not checking if the schemas on the lowerBound and upperBound present in the RangePartitionWithCustomHashSchema are equal?



-- 
To view, visit http://gerrit.cloudera.org:8080/18589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieaab7a79d4336de7ff6ec84b8c1806407e4fa44e
Gerrit-Change-Number: 18589
Gerrit-PatchSet: 7
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Jul 2022 02:46:51 +0000
Gerrit-HasComments: Yes