You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/30 18:08:38 UTC

[GitHub] [flink] reswqa opened a new pull request, #21437: [FLINK-27944] Input channel metric will no longer be registered multiple times

reswqa opened a new pull request, #21437:
URL: https://github.com/apache/flink/pull/21437

   ## What is the purpose of the change
   
   *If a task has multiple input gates, It will create as many `InputChannelMetrics` as the number of gates, so the corresponding metrics are registered repeatedly. This pull request aimed to fix this problem. *
   
   
   ## Brief change log
   
     - *Create `InputChannelMetrics` in `NettyShuffleEnvironment#createInputGates`.*
   
   
   ## Verifying this change
   
   This change added unit test in `NettyShuffleEnvironmentTest`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] pnowojski merged pull request #21437: [FLINK-27944] Input channel metric will no longer be registered multiple times

Posted by GitBox <gi...@apache.org>.
pnowojski merged PR #21437:
URL: https://github.com/apache/flink/pull/21437


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] reswqa commented on pull request #21437: [FLINK-27944] Input channel metric will no longer be registered multiple times

Posted by GitBox <gi...@apache.org>.
reswqa commented on PR #21437:
URL: https://github.com/apache/flink/pull/21437#issuecomment-1332561864

   Hi @pnowojski, Would you mind helping me to take a look this pull request when you have time? Thanks very much~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] reswqa commented on pull request #21437: [FLINK-27944] Input channel metric will no longer be registered multiple times

Posted by GitBox <gi...@apache.org>.
reswqa commented on PR #21437:
URL: https://github.com/apache/flink/pull/21437#issuecomment-1333642182

   @pnowojski Thank you very much for reminding me. 
   I'm sorry for forgetting this. I still keep two commits, but add Xiaogang as a co-author on the second one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21437: [FLINK-27944] Input channel metric will no longer be registered multiple times

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21437:
URL: https://github.com/apache/flink/pull/21437#issuecomment-1332557385

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "945e55446238871a9c0e464296fa054749f6b097",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "945e55446238871a9c0e464296fa054749f6b097",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 945e55446238871a9c0e464296fa054749f6b097 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org