[jira] [Resolved] (ARROW-6558) [C++] Refactor Iterator to a type erased handle

["Benjamin Kietzman (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARROW-6558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Kietzman resolved ARROW-6558.
--------------------------------------
    Fix Version/s: 0.15.0
       Resolution: Fixed

Issue resolved by pull request 5391
[https://github.com/apache/arrow/pull/5391]

> [C++] Refactor Iterator to a type erased handle
> -----------------------------------------------
>
>                 Key: ARROW-6558
>                 URL: https://issues.apache.org/jira/browse/ARROW-6558
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Benjamin Kietzman
>            Assignee: Benjamin Kietzman
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.15.0
>
>          Time Spent: 5h 10m
>  Remaining Estimate: 0h
>
> Since {{Iterator<T>}} is used as a base class for exported classes and is instantiated in both arrow.dll and arrow_dataset.dll we get multiple definition errors. The solution taken by MSVC's stl implementation in the similar case of {{std::function}} is type erasure. Since it's not a base class MSVC doesn't force public visibility of its members. 



--
This message was sent by Atlassian Jira
(v8.3.2#803003)