You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/09/19 19:21:29 UTC
[GitHub] [incubator-kyuubi] pan3793 opened a new pull request, #3521: Test: Fix Flink flaky test execute statement - select count
pan3793 opened a new pull request, #3521:
URL: https://github.com/apache/incubator-kyuubi/pull/3521
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
Fix the flaky test
```
- execute statement - select count *** FAILED ***
92 did not equal 100 (FlinkOperationSuite.scala:663)
```
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #3521: [TEST] Fix Flink flaky test - select count
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #3521:
URL: https://github.com/apache/incubator-kyuubi/pull/3521#issuecomment-1256927431
we override the `<log4j2.configurationFile>src/test/resources/log4j2-test.xml</log4j2.configurationFile>` in `scalatest-maven-plugin`, you mean it does not take effect?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] link3280 commented on pull request #3521: [TEST] Fix Flink flaky test - select count
Posted by GitBox <gi...@apache.org>.
link3280 commented on PR #3521:
URL: https://github.com/apache/incubator-kyuubi/pull/3521#issuecomment-1251982911
I think this could be a temporary fix if it causes instability in tests. But I can't reproduce the issue, the test runs fine on my machine.
I had a glance at the git history and found that this test is for validating changes to table statistics. IMHO, row counts from table metadata should be only used for query optimization, not for the actual result set, thus I'm thinking if the assert is necessary at the beginning (or we just wanna ensure the statement runs).
Pulling in the author @liaoyt for his opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #3521: [TEST] Fix Flink flaky test - select count
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #3521:
URL: https://github.com/apache/incubator-kyuubi/pull/3521#issuecomment-1263328927
Tracking in #3583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #3521: [TEST] Fix Flink flaky test - select count
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #3521:
URL: https://github.com/apache/incubator-kyuubi/pull/3521#issuecomment-1257771815
It's open for a long time, I'm going to merge it to fix the frequent test failures, although I don't know what happened under the hood.
Feel free to rework this test case if you have any ideas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 closed pull request #3521: [TEST] Fix Flink flaky test - select count
Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #3521: [TEST] Fix Flink flaky test - select count
URL: https://github.com/apache/incubator-kyuubi/pull/3521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #3521: [TEST] Fix Flink flaky test - select count
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on PR #3521:
URL: https://github.com/apache/incubator-kyuubi/pull/3521#issuecomment-1251804826
changes expected or bug? and do you have any chance to elaborate about the reason?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #3521: [TEST] Fix Flink flaky test - select count
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on PR #3521:
URL: https://github.com/apache/incubator-kyuubi/pull/3521#issuecomment-1263315209
> It's open for a long time, I'm going to merge it to fix the frequent test failures, although I don't know what happened under the hood.
>
> Feel free to rework this test case if you have any ideas.
If this is not a complete solution, it might be better to add `// TODO` with your change. And an issue ticket is also recommended.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #3521: [TEST] Fix Flink flaky test - select count
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #3521:
URL: https://github.com/apache/incubator-kyuubi/pull/3521#issuecomment-1255800455
cc @deadwind4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] cxzl25 commented on pull request #3521: [TEST] Fix Flink flaky test - select count
Posted by GitBox <gi...@apache.org>.
cxzl25 commented on PR #3521:
URL: https://github.com/apache/incubator-kyuubi/pull/3521#issuecomment-1256920296
I tried adding multiple loops to this ut, and I can indeed reproduce this problem.
But from the log, I found nothing unusual.
In addition, because `flink-runtime-1.15.2-tests.jar` contains `log4j2-test.properties`, `rootLogger.level = OFF` is set, the priority of `log4j-test2.xml` in kyuubi is lower than that of properties, it does not take effect, in the test of Flink some logs are missing, should we change the `log4j-test2.xml` of this flink module to `log4j2-test.properties`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] cxzl25 commented on pull request #3521: [TEST] Fix Flink flaky test - select count
Posted by GitBox <gi...@apache.org>.
cxzl25 commented on PR #3521:
URL: https://github.com/apache/incubator-kyuubi/pull/3521#issuecomment-1256931996
> we override the `<log4j2.configurationFile>src/test/resources/log4j2-test.xml</log4j2.configurationFile>` in `scalatest-maven-plugin`, you mean it does not take effect?
The flink test log downloaded from GA does have output logs.
Test with `./build/mvn test`, there are also output logs.
Maybe I use IDEA's scala test (org.jetbrains.plugins.scala.testingSupport.scalaTest.ScalaTestRunner), so there is no `log4j2.configurationFile` configured with scalatest-maven-plugin, then no log output in debug mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #3521: [TEST] Fix Flink flaky test - select count
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #3521:
URL: https://github.com/apache/incubator-kyuubi/pull/3521#issuecomment-1251805642
cc @SteNicholas @link3280 could you please confirm if the change makes sense or not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org