You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/07/29 03:44:48 UTC
[GitHub] [incubator-uniffle] zuston opened a new pull request, #100: [Improvement] Introduce config to customize assignment server numbers in client side
zuston opened a new pull request, #100:
URL: https://github.com/apache/incubator-uniffle/pull/100
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://github.com/Tencent/Firestorm/blob/master/CONTRIBUTING.md
2. Ensure you have added or run the appropriate tests for your PR
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]XXXX Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
[Improvement] Introduce config to customize assignment server numbers in client side.
**Changelog**
1. Introduce the config of `<client_type>.rss.client.assignment.shuffle.server.number`
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
Now the assignment number specified by coordinator's conf of rss.coordinator.shuffle.nodes.max. But i think it's not suitable for all spark jobs.
We should introduce new config to let client specify the assignment server number. rss.coordinator.shuffle.nodes.max should be as a max limitation of clients' number.
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
YES.
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
UT.
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #100: [Improvement] Introduce config to customize assignment server numbers in client side
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #100:
URL: https://github.com/apache/incubator-uniffle/pull/100#discussion_r934112581
##########
docs/client_guide.md:
##########
@@ -88,6 +88,7 @@ These configurations are shared by all types of clients.
|<client_type>.rss.client.send.threadPool.size|5|The thread size for send shuffle data to shuffle server|
|<client_type>.rss.client.assignment.tags|-|The comma-separated list of tags for deciding assignment shuffle servers. Notice that the SHUFFLE_SERVER_VERSION will always as the assignment tag whether this conf is set or not|
|<client_type>.rss.client.data.commit.pool.size|The number of assigned shuffle servers|The thread size for sending commit to shuffle servers|
+|<client_type>.rss.client.assignment.shuffle.nodes.max|-1|The number of required assignment shuffle servers. If it is less than 0 or greater than the coordinator's config of "rss.coordinator.shuffle.nodes.max", it will use the size of "rss.coordinator.shuffle.nodes.max" default|
Review Comment:
When the value is equal to 0, what will happen?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #100: [Improvement] Introduce config to customize assignment server numbers in client side
Posted by GitBox <gi...@apache.org>.
zuston commented on code in PR #100:
URL: https://github.com/apache/incubator-uniffle/pull/100#discussion_r934439328
##########
coordinator/src/test/java/org/apache/uniffle/coordinator/BasicAssignmentStrategyTest.java:
##########
@@ -147,4 +149,79 @@ public void testAssignWithDifferentNodeNum() {
assertTrue(serverNodes.contains(sn2));
assertTrue(serverNodes.contains(sn3));
}
+
+ @Test
+ public void testAssignmentShuffleNodesNum() {
+ Set<String> serverTags = Sets.newHashSet("tag-1");
+
+ for (int i = 0; i < 20; ++i) {
+ clusterManager.add(new ServerNode("t1-" + i, "", 0, 0, 0,
+ 20 - i, 0, serverTags, true));
+ }
+
+ /**
+ * case1: user specify the illegal shuffle node num(<0)
+ * it will use the default shuffle nodes num when having enough servers.
+ */
+ PartitionRangeAssignment pra = strategy.assign(100, 10, 1, serverTags, -1);
Review Comment:
update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #100: [Improvement] Introduce config to customize assignment server numbers in client side
Posted by GitBox <gi...@apache.org>.
zuston commented on PR #100:
URL: https://github.com/apache/incubator-uniffle/pull/100#issuecomment-1198851200
Ping @jerqi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #100: [Improvement] Introduce config to customize assignment server numbers in client side
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #100:
URL: https://github.com/apache/incubator-uniffle/pull/100#issuecomment-1199007833
# [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/100?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#100](https://codecov.io/gh/apache/incubator-uniffle/pull/100?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9b1aef7) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/cdbacca19736fd1eccc8ab65c085ec4455d74c71?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cdbacca) will **decrease** coverage by `0.83%`.
> The diff coverage is `58.82%`.
```diff
@@ Coverage Diff @@
## master #100 +/- ##
============================================
- Coverage 56.34% 55.51% -0.84%
+ Complexity 1175 1106 -69
============================================
Files 149 140 -9
Lines 7977 7627 -350
Branches 765 737 -28
============================================
- Hits 4495 4234 -261
+ Misses 3239 3160 -79
+ Partials 243 233 -10
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-uniffle/pull/100?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/hadoop/mapreduce/RssMRConfig.java](https://codecov.io/gh/apache/incubator-uniffle/pull/100/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvbWFwcmVkdWNlL1Jzc01SQ29uZmlnLmphdmE=) | `66.66% <ø> (ø)` | |
| [...apache/hadoop/mapreduce/v2/app/RssMRAppMaster.java](https://codecov.io/gh/apache/incubator-uniffle/pull/100/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvbWFwcmVkdWNlL3YyL2FwcC9Sc3NNUkFwcE1hc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...he/uniffle/client/impl/ShuffleWriteClientImpl.java](https://codecov.io/gh/apache/incubator-uniffle/pull/100/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NsaWVudC9pbXBsL1NodWZmbGVXcml0ZUNsaWVudEltcGwuamF2YQ==) | `25.95% <ø> (ø)` | |
| [...rg/apache/uniffle/client/util/RssClientConfig.java](https://codecov.io/gh/apache/incubator-uniffle/pull/100/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NsaWVudC91dGlsL1Jzc0NsaWVudENvbmZpZy5qYXZh) | `0.00% <ø> (ø)` | |
| [...he/uniffle/coordinator/CoordinatorGrpcService.java](https://codecov.io/gh/apache/incubator-uniffle/pull/100/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3IvQ29vcmRpbmF0b3JHcnBjU2VydmljZS5qYXZh) | `2.33% <0.00%> (-0.03%)` | :arrow_down: |
| [...e/uniffle/coordinator/BasicAssignmentStrategy.java](https://codecov.io/gh/apache/incubator-uniffle/pull/100/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3IvQmFzaWNBc3NpZ25tZW50U3RyYXRlZ3kuamF2YQ==) | `96.77% <100.00%> (+0.34%)` | :arrow_up: |
| [...rg/apache/uniffle/coordinator/CoordinatorConf.java](https://codecov.io/gh/apache/incubator-uniffle/pull/100/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3IvQ29vcmRpbmF0b3JDb25mLmphdmE=) | `96.15% <100.00%> (ø)` | |
| [...oordinator/PartitionBalanceAssignmentStrategy.java](https://codecov.io/gh/apache/incubator-uniffle/pull/100/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3IvUGFydGl0aW9uQmFsYW5jZUFzc2lnbm1lbnRTdHJhdGVneS5qYXZh) | `98.46% <100.00%> (+4.91%)` | :arrow_up: |
| [...storage/handler/impl/DataSkippableReadHandler.java](https://codecov.io/gh/apache/incubator-uniffle/pull/100/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmFnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdW5pZmZsZS9zdG9yYWdlL2hhbmRsZXIvaW1wbC9EYXRhU2tpcHBhYmxlUmVhZEhhbmRsZXIuamF2YQ==) | `81.25% <0.00%> (-3.13%)` | :arrow_down: |
| [...org/apache/uniffle/server/ShuffleFlushManager.java](https://codecov.io/gh/apache/incubator-uniffle/pull/100/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9TaHVmZmxlRmx1c2hNYW5hZ2VyLmphdmE=) | `76.70% <0.00%> (-1.71%)` | :arrow_down: |
| ... and [13 more](https://codecov.io/gh/apache/incubator-uniffle/pull/100/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #100: [Improvement] Introduce config to customize assignment server numbers in client side
Posted by GitBox <gi...@apache.org>.
zuston commented on PR #100:
URL: https://github.com/apache/incubator-uniffle/pull/100#issuecomment-1199094395
How to rerun the CI @jerqi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #100: [Improvement] Introduce config to customize assignment server numbers in client side
Posted by GitBox <gi...@apache.org>.
zuston commented on code in PR #100:
URL: https://github.com/apache/incubator-uniffle/pull/100#discussion_r933754637
##########
client/src/main/java/org/apache/uniffle/client/util/RssClientConfig.java:
##########
@@ -65,4 +65,8 @@ public class RssClientConfig {
public static final int RSS_ACCESS_TIMEOUT_MS_DEFAULT_VALUE = 10000;
public static final String RSS_DYNAMIC_CLIENT_CONF_ENABLED = "rss.dynamicClientConf.enabled";
public static final boolean RSS_DYNAMIC_CLIENT_CONF_ENABLED_DEFAULT_VALUE = true;
+
+ public static final String RSS_CLIENT_ASSIGNMENT_SHUFFLE_SERVER_NUMBER =
+ "rss.client.assignment.shuffle.server.number";
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #100: [Improvement] Introduce config to customize assignment server numbers in client side
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #100:
URL: https://github.com/apache/incubator-uniffle/pull/100#issuecomment-1199128614
> How to rerun the CI @jerqi
Close and reopen pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] colinmjj commented on pull request #100: [Improvement] Introduce config to customize assignment server numbers in client side
Posted by GitBox <gi...@apache.org>.
colinmjj commented on PR #100:
URL: https://github.com/apache/incubator-uniffle/pull/100#issuecomment-1200634872
> > @zuston Thanks for the contribution, it's flexible for different kind of jobs. And please update `Constants.SHUFFLE_SERVER_VERSION` for version compatible.
>
> It should be a compatible feature, we don't need update the `Constants.SHUFFLE_SERVER_VERSION`.
ok, it's only updated for coordinator.
+1, LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston closed pull request #100: [Improvement] Introduce config to customize assignment server numbers in client side
Posted by GitBox <gi...@apache.org>.
zuston closed pull request #100: [Improvement] Introduce config to customize assignment server numbers in client side
URL: https://github.com/apache/incubator-uniffle/pull/100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi merged pull request #100: [Improvement] Introduce config to customize assignment server numbers in client side
Posted by GitBox <gi...@apache.org>.
jerqi merged PR #100:
URL: https://github.com/apache/incubator-uniffle/pull/100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #100: [Improvement] Introduce config to customize assignment server numbers in client side
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #100:
URL: https://github.com/apache/incubator-uniffle/pull/100#issuecomment-1200633359
> @zuston Thanks for the contribution, it's flexible for different kind of jobs. And please update `Constants.SHUFFLE_SERVER_VERSION` for version compatible.
It should be a compatible feature, we don't need update the `Constants.SHUFFLE_SERVER_VERSION`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] colinmjj commented on pull request #100: [Improvement] Introduce config to customize assignment server numbers in client side
Posted by GitBox <gi...@apache.org>.
colinmjj commented on PR #100:
URL: https://github.com/apache/incubator-uniffle/pull/100#issuecomment-1200630981
@zuston Thanks for the contribution, it's flexible for different kind of jobs. And please update `Constants.SHUFFLE_SERVER_VERSION` for version compatible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #100: [Improvement] Introduce config to customize assignment server numbers in client side
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #100:
URL: https://github.com/apache/incubator-uniffle/pull/100#discussion_r934112991
##########
coordinator/src/test/java/org/apache/uniffle/coordinator/BasicAssignmentStrategyTest.java:
##########
@@ -147,4 +149,79 @@ public void testAssignWithDifferentNodeNum() {
assertTrue(serverNodes.contains(sn2));
assertTrue(serverNodes.contains(sn3));
}
+
+ @Test
+ public void testAssignmentShuffleNodesNum() {
+ Set<String> serverTags = Sets.newHashSet("tag-1");
+
+ for (int i = 0; i < 20; ++i) {
+ clusterManager.add(new ServerNode("t1-" + i, "", 0, 0, 0,
+ 20 - i, 0, serverTags, true));
+ }
+
+ /**
+ * case1: user specify the illegal shuffle node num(<0)
+ * it will use the default shuffle nodes num when having enough servers.
+ */
+ PartitionRangeAssignment pra = strategy.assign(100, 10, 1, serverTags, -1);
Review Comment:
Could you add a case when assignShuffleServer is equal to 0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #100: [Improvement] Introduce config to customize assignment server numbers in client side
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #100:
URL: https://github.com/apache/incubator-uniffle/pull/100#discussion_r933406917
##########
client/src/main/java/org/apache/uniffle/client/util/RssClientConfig.java:
##########
@@ -65,4 +65,8 @@ public class RssClientConfig {
public static final int RSS_ACCESS_TIMEOUT_MS_DEFAULT_VALUE = 10000;
public static final String RSS_DYNAMIC_CLIENT_CONF_ENABLED = "rss.dynamicClientConf.enabled";
public static final boolean RSS_DYNAMIC_CLIENT_CONF_ENABLED_DEFAULT_VALUE = true;
+
+ public static final String RSS_CLIENT_ASSIGNMENT_SHUFFLE_SERVER_NUMBER =
+ "rss.client.assignment.shuffle.server.number";
Review Comment:
`rss.client.assignment.shuffle.node.max`
Could we use a similar style name with the coordinator's configuration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #100: [Improvement] Introduce config to customize assignment server numbers in client side
Posted by GitBox <gi...@apache.org>.
zuston commented on PR #100:
URL: https://github.com/apache/incubator-uniffle/pull/100#issuecomment-1200149272
Updated @jerqi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #100: [Improvement] Introduce config to customize assignment server numbers in client side
Posted by GitBox <gi...@apache.org>.
zuston commented on code in PR #100:
URL: https://github.com/apache/incubator-uniffle/pull/100#discussion_r934334919
##########
docs/client_guide.md:
##########
@@ -88,6 +88,7 @@ These configurations are shared by all types of clients.
|<client_type>.rss.client.send.threadPool.size|5|The thread size for send shuffle data to shuffle server|
|<client_type>.rss.client.assignment.tags|-|The comma-separated list of tags for deciding assignment shuffle servers. Notice that the SHUFFLE_SERVER_VERSION will always as the assignment tag whether this conf is set or not|
|<client_type>.rss.client.data.commit.pool.size|The number of assigned shuffle servers|The thread size for sending commit to shuffle servers|
+|<client_type>.rss.client.assignment.shuffle.nodes.max|-1|The number of required assignment shuffle servers. If it is less than 0 or greater than the coordinator's config of "rss.coordinator.shuffle.nodes.max", it will use the size of "rss.coordinator.shuffle.nodes.max" default|
Review Comment:
If it is less than 0 or equal to 0 or greater than the coordinator's config of "rss.coordinator.shuffle.nodes.max", it will use the size of "rss.coordinator.shuffle.nodes.max" default.
I missed the condition of ==0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org