You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/06/15 04:20:48 UTC
[GitHub] wu-sheng closed pull request #1353: Add the Logger modifier
"static" in pr #1347
wu-sheng closed pull request #1353: Add the Logger modifier "static" in pr #1347
URL: https://github.com/apache/incubator-skywalking/pull/1353
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/apm-collector/apm-collector-component/client-component/src/main/java/org/apache/skywalking/apm/collector/client/shardingjdbc/ShardingjdbcClient.java b/apm-collector/apm-collector-component/client-component/src/main/java/org/apache/skywalking/apm/collector/client/shardingjdbc/ShardingjdbcClient.java
index 0a2fd3bd0..318497036 100644
--- a/apm-collector/apm-collector-component/client-component/src/main/java/org/apache/skywalking/apm/collector/client/shardingjdbc/ShardingjdbcClient.java
+++ b/apm-collector/apm-collector-component/client-component/src/main/java/org/apache/skywalking/apm/collector/client/shardingjdbc/ShardingjdbcClient.java
@@ -43,7 +43,7 @@
*/
public class ShardingjdbcClient implements Client {
- private final Logger logger = LoggerFactory.getLogger(ShardingjdbcClient.class);
+ private static final Logger logger = LoggerFactory.getLogger(ShardingjdbcClient.class);
private Map<String, ShardingjdbcClientConfig> shardingjdbcClientConfig;
diff --git a/apm-collector/apm-collector-storage/collector-storage-shardingjdbc-provider/src/main/java/org/apache/skywalking/apm/collector/storage/shardingjdbc/base/define/ShardingjdbcStorageInstaller.java b/apm-collector/apm-collector-storage/collector-storage-shardingjdbc-provider/src/main/java/org/apache/skywalking/apm/collector/storage/shardingjdbc/base/define/ShardingjdbcStorageInstaller.java
index 716f66c09..975a2a87d 100644
--- a/apm-collector/apm-collector-storage/collector-storage-shardingjdbc-provider/src/main/java/org/apache/skywalking/apm/collector/storage/shardingjdbc/base/define/ShardingjdbcStorageInstaller.java
+++ b/apm-collector/apm-collector-storage/collector-storage-shardingjdbc-provider/src/main/java/org/apache/skywalking/apm/collector/storage/shardingjdbc/base/define/ShardingjdbcStorageInstaller.java
@@ -36,7 +36,7 @@
*/
public class ShardingjdbcStorageInstaller extends StorageInstaller {
- private final Logger logger = LoggerFactory.getLogger(ShardingjdbcStorageInstaller.class);
+ private static final Logger logger = LoggerFactory.getLogger(ShardingjdbcStorageInstaller.class);
public ShardingjdbcStorageInstaller(boolean isHighPerformanceMode) {
super(isHighPerformanceMode);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services