You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/10/01 07:28:14 UTC

[GitHub] twalthr commented on a change in pull request #6611: [FLINK-3875] [connectors] Add an upsert table sink factory for Elasticsearch

twalthr commented on a change in pull request #6611: [FLINK-3875] [connectors] Add an upsert table sink factory for Elasticsearch
URL: https://github.com/apache/flink/pull/6611#discussion_r221513851
 
 

 ##########
 File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/StreamTableDescriptor.scala
 ##########
 @@ -96,6 +96,6 @@ class StreamTableDescriptor(
 
     // this performs only basic validation
     // more validation can only happen within a factory
-    new StreamTableDescriptorValidator().validate(properties)
+    new StreamTableDescriptorValidator(true, true, true).validate(properties)
 
 Review comment:
   I think we can also remove it. As the comment suggests it doesn't check much.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services